Chat Deselection Workflow #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Measurity
approved these changes
Sep 25, 2024
Jannify
requested changes
Sep 25, 2024
in scenarios such as: - an actual message was sent - no message was sent (null or empty) - message contains only whitespaces With these changes, the hardcoded "Y" key bind is also no longer needed.
|
I tinkered with this a bit and made a PR at MistaOmega#1 for some modifications, which I believe achieve the desired functionality, based on the description provided in the issue. I hope this is the correct way to PR these changes? I was a little baffled on how I should deliver them, but ultimately decided to make the PR to the fork of the original author in the hopes that I won't totally overstep the line, hehe ^^'. |
Make chat defocus and hiding better
|
This should now have @Risusama's changes in here too (ty for that :) ) |
dartasen
reviewed
Nov 11, 2024
dartasen
approved these changes
Nov 12, 2024
|
Works well IG, nice addition |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial Closes #2159