Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enlighten demo #15

Open
Wulfheart opened this issue Jan 5, 2021 · 2 comments
Open

Enlighten demo #15

Wulfheart opened this issue Jan 5, 2021 · 2 comments

Comments

@Wulfheart
Copy link

Seeding: Database\Seeders\SkillSeeder

   TypeError

  join(): Argument #2 ($array) must be of type ?array, string given

  at vendor/fzaninotto/faker/src/Faker/Provider/Lorem.php:95
     91▕
     92▕         $words = static::words($nbWords);
     93▕         $words[0] = ucwords($words[0]);
     94▕
  ➜  95▕         return join($words, ' ') . '.';
     96▕     }
     97▕
     98▕     /**
     99▕      * Generate an array of sentences

      +6 vendor frames
  7   database/factories/SkillFactory.php:26
      Faker\UniqueGenerator::__call()

      +8 vendor frames
  16  database/seeders/SkillSeeder.php:17
      Illuminate\Database\Eloquent\Factories\Factory::create()

However, I'm using php8. I was to lazy to downgrade.

@lucidlogic
Copy link

https://www.php.net/manual/en/function.implode.php

8.0.0 | Passing the separator after the array is no longer supported.

@lucidlogic
Copy link

for PHP 8 compatibility line 95 would have to be
return join(' ', $words) . '.';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants