Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfinished Wordpress post embeds #11

Open
petrkucerak opened this issue Sep 15, 2020 · 10 comments
Open

Unfinished Wordpress post embeds #11

petrkucerak opened this issue Sep 15, 2020 · 10 comments
Labels
problem Problem that needs to be fixed

Comments

@petrkucerak
Copy link
Member

image

@petrkucerak petrkucerak added the problem Problem that needs to be fixed label Sep 15, 2020
@filiptronicek filiptronicek changed the title Not done embded wordpress post Unfinished Wordpress post embeds Feb 8, 2021
@petrkucerak petrkucerak self-assigned this Feb 10, 2021
@petrkucerak
Copy link
Member Author

Please assingnee Pepik @petrkucerak

@filiptronicek filiptronicek assigned kahy9 and unassigned petrkucerak Feb 10, 2021
@petrkucerak
Copy link
Member Author

@kahy9 let's go styling!

@petrkucerak
Copy link
Member Author

@filiptronicek filiptronicek added this to the Week 4/19/2021 milestone Apr 21, 2021
@petrkucerak
Copy link
Member Author

any update @kahy9 ?

@petrkucerak petrkucerak modified the milestones: Week 4/19/2021, Week 19/05/2021 May 5, 2021
@petrkucerak
Copy link
Member Author

@filiptronicek wp manages to embed the post strangely.

Try to inspect our files:

Embed post can be managed by 4 files:

  • embed.php
  • embed-404.php
  • header-embed.php
  • footer-embed.php

Maybe our file embed.php not include some important part?

@filiptronicek
Copy link

filiptronicek commented May 10, 2021

@filiptronicek wp manages to embed the post strangely.

Try to inspect our files:

* [`main`/embed-content.php](https://github.com/MicrosoftSTC/stcblog/blob/main/embed-content.php)

* [`main`/assets/scss/_wp-embed.scss](https://github.com/MicrosoftSTC/stcblog/blob/main/assets/scss/_wp-embed.scss)

Embed post can be managed by 4 files:

* embed.php

* embed-404.php

* header-embed.php

* footer-embed.php

Maybe our file embed.php not include some important part?

I looked into this, from yesterday's late-night research, I have found, that the problem is probably with embed-content.php, as you have suggested. The thumbnail loads, the title as well as the description. They just won't show for some reason. They don't have a display: none, nor do they have their visibility set to hidden. I am thinking maybe there is an overflow (will look into that), but if it isn't the case, I really have no idea what else could cause this.

An interesting thing I found is that when you uncomment the inline style of position: absolute;, you can see the thumbnail image of the post. Also, when you then shrink the viewport to a mobile view, sometimes the entire post preview is rendered just fine.
Screen Shot 2021-05-10 at 13 34 29

/cc @petrkucerak @kahy9

@filiptronicek
Copy link

Hah, of course, it's not that easy. The position: absolute is defined inline in the _oembed_filter_feed_content function in embed.php. This means, that we need to either somehow replace that function, or add an inline position: unset !important.

@filiptronicek
Copy link

Also, deleting embed-content.php didn't help, the native post embed still didn't appear on the page.

@filiptronicek
Copy link

Also, when I comment out the absolute positioning, I still am left with the old link.
image

@petrkucerak
Copy link
Member Author

@kahy9 any update?

@Vilican Vilican removed this from the Week 19/05/2021 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem Problem that needs to be fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants