Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is new moon supposed to be visible in Stellarium? #997

Closed
10110111 opened this issue Mar 14, 2020 · 5 comments
Closed

Is new moon supposed to be visible in Stellarium? #997

10110111 opened this issue Mar 14, 2020 · 5 comments

Comments

@10110111
Copy link
Contributor

Playing with different renderings of the atmosphere, I've noticed that sometimes new moon is too visible (even when zoomed in to avoid the "fat dot" form), unlike in real life. At first I thought it was related to desynchronization with atmosphere rendering, but then I found this with the default atmosphere model too.
Also, sometimes it isn't as unrealistically visible, which makes me wonder, whether Stellarium wants to somehow emphasize the lunar disk (like in the solar eclipse event), or it aims at a more realistic rendering so that the extra visibility is a bug.

Examples of renderings (with the current out-of-the-box atmosphere):

  • Invisible Moon (as expected)

Screenshot - 140320 - 08:20:29

  • Visible Moon (physically wrong but might be on purpose(?))

Screenshot - 140320 - 08:21:43

  • Visible at eclipse (might be on purpose(?))

Screenshot - 140320 - 08:36:23

I suppose the second one, where the Moon is too visible, is simply a forgotten/neglected case when the solar flare is rendered as something behind the Moon, thus resulting in too visible lunar disk, because if I zoom in the second case so that the flare is no longer rendered, the Moon is again mostly invisible:
Screenshot - 140320 - 08:26:05

So, is the lunar disk of the full moon supposed to be visible? Or should the rendering with the flare behind and similar misrepresentations be fixed?

@gzotti
Copy link
Member

gzotti commented Mar 14, 2020

The slight visibility of the Lunar disc next to the Sun is indeed very much on purpose and intended. There are algorithms which could numerically decide whether it is theoretically visible or not, based on elongation, altitude and atmospheric factors, but these have not been implemented (in fact not even researched in detail yet), otherwise we could add yet another switch for those users aiming at maximum "realism". However, the moon, even if theoretically invisible, would have to mask off planets near solar conjunction or stars which it may occult. You will also see that the solar "glare" is a texture which is rendered in a fixed size in screen space. This is also "unrealistic". When you zoom out to max, you see the solar glare when the sun is way below the horizon. There are effects here and there which you could improve in "just a few hours", if it really annoys you. Feel invited.

@10110111
Copy link
Contributor Author

By "slight" visibility do you mean the 4th screenshot or the 2nd? Which of these is the supposed look? If the 2nd is not what it was supposed to be, I might try looking into how to fix this.

@gzotti
Copy link
Member

gzotti commented Mar 14, 2020

It is good to know where the moon is in relation to the sun. The current look is basically OK and should be achievable also in later editions. If you want to improve realism, you can add an alternative path with an additional setting ("Hide Moon close to Sun (more realistic)" or "Accurate lunar visibility" or similar.) You can also make a variable-size solar glare that should vanish when you zoom in and should shrink when you zoom out, and probably should vanish when the sun is behind the landscape.

@10110111
Copy link
Contributor Author

Hmm, I guess all this should be done after I implement the new atmosphere.

Basically, current rendering is quite old-school: independently-rendered planets along with their halo, with the colors somehow deduced based not on the actual image, brightnesses of the objects disregarding their actual brightness ratios (e.g. one can't see anything except the solar disk when using a solar filter in real life, yet in Stellarium we still have blue sky after zooming in to the Sun to see the spots), etc..

I suppose a second rendering engine (enabled by an option in the config) aimed at realism should be added, which would draw all this in a physically-based manner, like

  1. Draw the objects with their real brightnesses into a floating-point texture
  2. Pass this texture to atmosphere renderer, which would take transmittance into account and draw scattered light and the correctly-extincted objects
  3. Post-process the resulting image to blur excessively-bright objects (so that glare will be automagically achieved)
  4. Apply photopic/scotopic adaptation

But OK, until the new atmosphere model is ready, this is just an idea for a future project.

@axd1967
Copy link
Contributor

axd1967 commented May 20, 2021

related to #1130

Here is what Stellarium produces for the partial solar eclipse of 2021-06-10 (51N3E); the Moon would not be visible at all.

image

while this is what happens when zooming in:

image

for_realism

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants