Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gazetteer labels misplaced when degrees-towards-zenith are negative #4174

Open
martignoni opened this issue Mar 3, 2025 · 3 comments · May be fixed by #4176
Open

Gazetteer labels misplaced when degrees-towards-zenith are negative #4174

martignoni opened this issue Mar 3, 2025 · 3 comments · May be fixed by #4176
Assignees
@martignoni
Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash
Milestone
25.1

Comments

@martignoni
Copy link
Contributor

martignoni commented Mar 3, 2025 •
edited
Loading

Expected Behaviour

When degrees-towards-zenith < 0 in gazetteer file, gazetteer labels should be displayed below the lower end of the line pointing to the polygon line, instead of above.

Actual Behaviour

Gazetteer labels are displayed above the lower end of the line pointing to the polygon line, which causes legibility issues when label's angle is eg. 45° (see screenshot).

Steps to reproduce

System

  • Stellarium version: Stellarium 25.0+ (v25.0.61-a8d2146 [master]) and Stellarium 24.4 for macOS 11.0+; Qt6; universal
  • Operating system: macOS Sequioa 15.3.1
  • Graphics Card: Radeon Pro 580X 8 Go and Apple M2 GPU
  • Screen type: Any (not applicable)

Landscape

  1. Add gazetteer file attached to a landscape folder (remove .txt from file name).
  2. Re-launch Stellarium.
  3. Select landscape with above mentioned gazetteer file.
  4. Set "Text angle" of labels to 45°.
  5. Observe that labels are displayed above the lower end of the line pointing to the polygon line

Logfile

Log file shows no problem. See attachment.

Image

gazetteer.en.utf8.txt

log.txt
@gzotti gzotti self-assigned this Mar 3, 2025
@gzotti gzotti added the enhancement Improve existing functionality label Mar 3, 2025
@gzotti gzotti added this to the 25.4 milestone Mar 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 3, 2025

Hello @martignoni!

Thank you for suggesting this enhancement.

@gzotti gzotti added the importance: low Small problem, rarely visible, no crash label Mar 3, 2025
@gzotti
Copy link
Member

gzotti commented Mar 3, 2025

Label was never planned below horizon. Not difficult, just not urgent.

@martignoni
Copy link
Contributor Author

Label was never planned below horizon.

This is indeed what I had imagined.

Not difficult, just not urgent.

I'll try to give it a look.

martignoni added a commit to martignoni/stellarium that referenced this issue Mar 4, 2025
@martignoni
feat: handle correctly landscape labels with negative angle
93802df 
- See issue Stellarium#4174.
- This also fixes a placement bug when angle = 0.
martignoni added a commit to martignoni/stellarium that referenced this issue Mar 4, 2025
@martignoni
feat: handle correctly landscape labels with negative angle
652c927 
- See issue Stellarium#4174.
- This also fixes a placement bug when angle = 0.
@martignoni martignoni linked a pull request Mar 4, 2025 that will close this issue
Open
14 tasks
@alex-w alex-w assigned martignoni and unassigned gzotti Mar 4, 2025
@alex-w alex-w modified the milestones: 25.4, 25.1 Mar 4, 2025
martignoni added a commit to martignoni/stellarium that referenced this issue Mar 5, 2025
@martignoni
feat: handle correctly landscape labels with negative angle
f04669f 
- See issue Stellarium#4174.
- This also fixes a placement bug when angle = 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martignoni martignoni

Labels
enhancement Improve existing functionality importance: low Small problem, rarely visible, no crash
Milestone
25.1
Development

Successfully merging a pull request may close this issue.

feat: handle correctly landscape labels with negative angle martignoni/stellarium
3 participants
@alex-w @martignoni @gzotti