Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont include tests in main mod. #187

Open
IMB11 opened this issue Jan 1, 2025 · 3 comments
Open

Dont include tests in main mod. #187

IMB11 opened this issue Jan 1, 2025 · 3 comments

Comments

@IMB11
Copy link

IMB11 commented Jan 1, 2025

Having a data generator entrypoint in the library mod will break datagen for other mods. It's just bad practice to include test stuff with the library itself as well.

See FabricMC/fabric#4330

@IMB11
Copy link
Author

IMB11 commented Jan 1, 2025

https://github.com/StellarWind22/Fabric-Shield-Lib/blob/main/src/main/java/com/github/crimsondawn45/fabricshieldlib/initializers/FabricShieldLib.java#L91 All of this should be in a test mod. I will do this in a PR for you in the coming days.

@CringeStar
Copy link
Collaborator

CringeStar commented Jan 2, 2025

Yeah this has caused issues for us in the past, one which I am currently trying to fix: the test enchantment showing up in the release. Before the shift to data, we used to be able to sweep it under the rug with a if(devEnviroment) check.

I will do this in a PR for you in the coming days.

That would be really helpful, thanks! I looked into that myself, but wasnt sure of the exact implementation within the project.

@CringeStar
Copy link
Collaborator

I will push a bandaid fix for said enchant issue to release the 1.21.3 port, but if you make a PR, please do it to the 1.21.3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants