-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont include tests in main mod. #187
Comments
https://github.com/StellarWind22/Fabric-Shield-Lib/blob/main/src/main/java/com/github/crimsondawn45/fabricshieldlib/initializers/FabricShieldLib.java#L91 All of this should be in a test mod. I will do this in a PR for you in the coming days. |
Yeah this has caused issues for us in the past, one which I am currently trying to fix: the test enchantment showing up in the release. Before the shift to data, we used to be able to sweep it under the rug with a if(devEnviroment) check.
That would be really helpful, thanks! I looked into that myself, but wasnt sure of the exact implementation within the project. |
I will push a bandaid fix for said enchant issue to release the 1.21.3 port, but if you make a PR, please do it to the 1.21.3 branch. |
Having a data generator entrypoint in the library mod will break datagen for other mods. It's just bad practice to include test stuff with the library itself as well.
See FabricMC/fabric#4330
The text was updated successfully, but these errors were encountered: