Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinterCop is compiled with debug configuration #457

Closed
dannoe opened this issue Dec 19, 2023 · 4 comments · Fixed by #458
Closed

LinterCop is compiled with debug configuration #457

dannoe opened this issue Dec 19, 2023 · 4 comments · Fixed by #458
Labels
enhancement New feature or request

Comments

@dannoe
Copy link
Contributor

dannoe commented Dec 19, 2023 •
edited
Loading

Is this intentional?

If not, I would recommend building with the release configuration in the pipeline. With debug, the compiler will not optimize the assembly. This improves performance even more.
@Arthurvdv Arthurvdv linked a pull request Dec 19, 2023 that will close this issue
Build using Release configuration #458
Merged
@Arthurvdv
Copy link
Collaborator

Is this intentional?

I'm not aware if this was intentional, could be it just works™ settings 😅

Thank you for suggesting this, I didn't realize the difference between Debug and Release. I've updated the (pre)release v0.30.10 version of the LinterCop which is build with the Release configuration.

@Arthurvdv Arthurvdv added the enhancement New feature or request label Dec 19, 2023
@jwikman
Copy link
Contributor

jwikman commented Dec 19, 2023

This seems to have reduced the overall time consumed by LC with 15-20% 👍

Any ETA of the release of v.0.30.10?
Asking since I was bit eager and removed some now, in pre-release, unnecessary pragmas. But I just realized that our pipelines are not running pre-release version and hence failed. 😅

@Arthurvdv
Copy link
Collaborator

@jwikman, I have good news; The v0.30.10 of the LinterCop is now released 🤗

@jwikman
Copy link
Contributor

jwikman commented Dec 20, 2023

Thanks @arthurvd! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build using Release configuration StefanMaron/BusinessCentral.LinterCop
3 participants
@dannoe @jwikman @Arthurvdv