Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

leading / on links to images causing deployment to sub paths not to load images #202

Closed
unstableunicorn opened this issue Apr 23, 2024 · 2 comments
Closed

leading / on links to images causing deployment to sub paths not to load images #202

unstableunicorn opened this issue Apr 23, 2024 · 2 comments

Comments

@unstableunicorn
Copy link
Contributor

When deploying to gitlab pages, which uses a subpath e.g. https://StefMa.gitlab.io/hugo-fresh/, images would not load correctly.
This is caused by the leading / when referencing static files.
Changing references from:
"/images/.../%s
to
"images/.../%s

Should make it compatible with both site configurations.

Currently testing and will submit a PR shortly.
@unstableunicorn unstableunicorn mentioned this issue Apr 23, 2024
Merged
@StefMa
Copy link
Owner

StefMa commented May 10, 2024

Fixed via #203.
And released with v1.1.0 https://github.com/StefMa/hugo-fresh/releases/tag/v1.1.0

Thanks again!

@StefMa StefMa closed this as completed May 10, 2024
@unstableunicorn
Copy link
Contributor Author

Fixed via #203. And released with v1.1.0 https://github.com/StefMa/hugo-fresh/releases/tag/v1.1.0

Thanks again!

Awesome! Glad I could help a little :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StefMa @unstableunicorn