Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moonraker backups #105

Open
PhilippMolitor opened this issue Jun 20, 2024 · 9 comments
Open

Moonraker backups #105

PhilippMolitor opened this issue Jun 20, 2024 · 9 comments
Labels
enhancement New feature or request ignore stale

Comments

@PhilippMolitor
Copy link

Is your feature request related to a problem? Please describe.

Moonraker has a built-in tool for creating database backups:
https://moonraker.readthedocs.io/en/latest/installation/?h=backup#database-backup-and-restore

It seems to create base64 encoded backups of the database.

Describe the solution you'd like

klipper-backup should be able to leverage the moonraker backup tool to create db backups. this would also be beneficial for the planned restore function.

Describe alternatives you've considered

I am currently using this config:

allow_empty_commits="false"

backupPaths=( \
"printer_data/config/*" \
"printer_data/database/*" \
)

Problems:

  • it creates a lot of empty commits because the DB file is written to very often, this can be circumvented with allow_empty_commits=false
  • the db files are binary, which clutters the git repo with non-diffable data.
  • if the database file is currently written to, it could result in a corrupt backup

Additional information

No response

@Tylerjet Tylerjet added the enhancement New feature or request label Jun 29, 2024
@Tylerjet
Copy link
Collaborator

This is something i looked at a while back but it can somtimes be a pain if i recall correctly, so will possibly look back into it in the future.

Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Jul 14, 2024
@PhilippMolitor
Copy link
Author

bump @ stale

@github-actions github-actions bot removed the stale label Jul 15, 2024
Tylerjet added a commit that referenced this issue Jul 16, 2024
…er_db_backup variable and functions for running moonraker backup/restore scripts - #105.
Tylerjet added a commit that referenced this issue Jul 16, 2024
@Tylerjet
Copy link
Collaborator

Tylerjet commented Jul 16, 2024

Added commit to restore-dev that will allow for a variable moonraker_db_backups to be set true/false that will run moonrakers backup script and will restore the database file if found on restore actions.

Scratch that just noticed i setup based on the deprecated method however base function for getting it working are now in place just a matter of chaging up how it calls to backup and where it gets the backup file from.

Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Jul 31, 2024
Copy link
Contributor

This issue was closed because it has been inactive for 14 days since being marked as stale.

@PhilippMolitor
Copy link
Author

please open again :)

@Staubgeborener Staubgeborener pinned this issue Aug 14, 2024
@github-actions github-actions bot removed the stale label Aug 15, 2024
Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Aug 29, 2024
@Tylerjet
Copy link
Collaborator

Tylerjet commented Aug 29, 2024

Hopefully now the actions bot will leave this alone. Potentially next month (or sooner if the job hunt goes well) i can resume work on the restore stuff and get this pushed to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ignore stale
Projects
None yet
Development

No branches or pull requests

3 participants