Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks should not log to console if failed gracefully #191

Open
DrewImm opened this issue Sep 5, 2019 · 0 comments
Open

Hooks should not log to console if failed gracefully #191

DrewImm opened this issue Sep 5, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@DrewImm
Copy link
Member

DrewImm commented Sep 5, 2019

Describe the bug
"Could not complete hook * on object:" error message displays, even if the hook failed gracefully (by returning false)

To Reproduce
Return false in any hook

Expected behavior
Message should only display if hook returns non-boolean value
@DrewImm DrewImm added bug Something isn't working breaking This issue will require a major version bump labels Sep 5, 2019
@DrewImm DrewImm removed the breaking This issue will require a major version bump label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DrewImm