Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing builds #541

Closed
Jose-Matsuda opened this issue Oct 10, 2023 · 1 comment
Closed

Fix Failing builds #541

Jose-Matsuda opened this issue Oct 10, 2023 · 1 comment

Comments

@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Oct 10, 2023

EDIT

Maybe just close this as Souheil is doing StatCan/aaw#1855 ?


See our recent nightly builds
https://github.com/StatCan/aaw-kubeflow-containers/actions/runs/6461703540

Copying over thread from Slack

Issue seems to be after that:
"@jupyterlab/[email protected]" is not compatible with the current JupyterLab
Conflicting Dependencies:
JupyterLab              Extension      Package
>=4.0.6 <4.1.0          >=1.0.0 <2.0.0||>=2.0.0 <3.0.0||>=3.0.0 <4.0.0@jupyterlab/application
>=4.1.6 <4.2.0          >=1.0.0 <2.0.0||>=2.0.0 <3.0.0||>=3.0.0 <4.0.0@jupyterlab/apputils
>=4.0.6 <4.1.0          >=1.0.0 <2.0.0||>=2.0.0 <3.0.0||>=3.0.0 <4.0.0@jupyterlab/launcher


Pat Ledgerwood

We're forcing the version of the server-proxy to 2.1.2 so that is easy enough to change... but I'm confused why it broke now, the version of jupyterlab we're using didn't change

Pat Ledgerwood
Should not have changed anyways... maybe they just updated the dependency information or something


Pat Ledgerwood

Maybe we should just get rid of those extension installs based on the meesage (Deprecated) Installing extensions with the jupyter labextension install command is now deprecated and will be removed in a future major version of JupyterLab.


Jose Matsuda
yeah unless we just address it directly


Pat Ledgerwood
Seems like they are not even installed properly anyway, if I look at the extensions in prod jupyter-server-proxy 4.0.0 extension is installed already and plotly is also a newer version than listed
@chuckbelisle
Copy link

Closing tasks as it became duplicate of work done in 1855 (linked above)

@chuckbelisle chuckbelisle closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants