-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add count_distinct_implementation/enable_count_distinct_rewrite_by_hll_bitmap to control count distinct's implmentation (backport #52293) #52334
Conversation
Cherry-pick of cc0f50f has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
…_rewrite_by_hll_bitmap to control count distinct's implmentation (#52293) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit cc0f50f)
8b9f152
to
fe731e4
Compare
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Quality Gate passedIssues Measures |
Why I'm doing:
By default, user's mv with
hll_union(hll_hash(x))
cannot be rewritten by mv.What I'm doing:
count_distinct_implementation(supports default/ndv/mulit_count_distinct)
to rewritecount (distinc x))
tondv(x)
ormulti_count_distinct(x)
;enable_count_distinct_rewrite_by_hll_bitmap
to control whether to use mv withhll/bitmap
to rewritecount distinct
, default:true.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #52293 done by [Mergify](https://mergify.com). ## Why I'm doing: By default, user's mv with `hll_union(hll_hash(x))` cannot be rewritten by mv.
What I'm doing:
count_distinct_implementation(supports default/ndv/mulit_count_distinct)
to rewritecount (distinc x))
tondv(x)
ormulti_count_distinct(x)
;enable_count_distinct_rewrite_by_hll_bitmap
to control whether to use mv withhll/bitmap
to rewritecount distinct
, default:true.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: