Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add count_distinct_implementation/enable_count_distinct_rewrite_by_hll_bitmap to control count distinct's implmentation (backport #52293) #52334

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 25, 2024

Why I'm doing:

By default, user's mv with hll_union(hll_hash(x)) cannot be rewritten by mv.

What I'm doing:

  • Add count_distinct_implementation(supports default/ndv/mulit_count_distinct) to rewrite count (distinc x)) to ndv(x) or multi_count_distinct(x);
  • Add enable_count_distinct_rewrite_by_hll_bitmap to control whether to use mv with hll/bitmap to rewrite count distinct, default:true.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52293 done by [Mergify](https://mergify.com). ## Why I'm doing: By default, user's mv with `hll_union(hll_hash(x))` cannot be rewritten by mv.

What I'm doing:

  • Add count_distinct_implementation(supports default/ndv/mulit_count_distinct) to rewrite count (distinc x)) to ndv(x) or multi_count_distinct(x);
  • Add enable_count_distinct_rewrite_by_hll_bitmap to control whether to use mv with hll/bitmap to rewrite count distinct, default:true.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Oct 25, 2024
Copy link
Contributor Author

mergify bot commented Oct 25, 2024

Cherry-pick of cc0f50f has failed:

On branch mergify/bp/branch-3.3/pr-52293
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit cc0f50fc94.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/qe/SessionVariableConstants.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/SetStmtAnalyzer.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/MaterializedViewRewriter.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/equivalent/BitmapRewriteEquivalent.java
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/statistics/CachedStatisticStorage.java
	modified:   fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java
	modified:   fe/fe-core/src/test/java/com/starrocks/sql/plan/AggregateTest.java
	modified:   test/lib/sr_sql_lib.py
	new file:   test/sql/test_materialized_view/R/test_materialized_view_rewrite_count_distinct
	new file:   test/sql/test_materialized_view/T/test_materialized_view_rewrite_count_distinct

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/main/java/com/starrocks/qe/SessionVariable.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/analyzer/FunctionAnalyzer.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/RewriteContext.java
	both modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/equivalent/HLLRewriteEquivalent.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Oct 25, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@LiShuMing LiShuMing reopened this Nov 11, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) November 11, 2024 02:38
…_rewrite_by_hll_bitmap to control count distinct's implmentation (#52293)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit cc0f50f)
@LiShuMing LiShuMing force-pushed the mergify/bp/branch-3.3/pr-52293 branch from 8b9f152 to fe731e4 Compare November 11, 2024 03:09
LiShuMing
LiShuMing previously approved these changes Nov 11, 2024
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
Copy link

sonarcloud bot commented Nov 11, 2024

@wanpengfei-git wanpengfei-git merged commit 20c61dd into branch-3.3 Nov 11, 2024
28 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-52293 branch November 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants