-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Support push down avg aggregate function in mv rewrite #52288
Merged
LiShuMing
merged 2 commits into
StarRocks:main
from
LiShuMing:fix/main/fix_mv_push_down_mv
Oct 25, 2024
Merged
[Enhancement] Support push down avg aggregate function in mv rewrite #52288
LiShuMing
merged 2 commits into
StarRocks:main
from
LiShuMing:fix/main/fix_mv_push_down_mv
Oct 25, 2024
+289
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuming.li <[email protected]>
Signed-off-by: shuming.li <[email protected]>
...arrocks/sql/optimizer/rule/transformation/materialization/common/AggregatePushDownUtils.java
Show resolved
Hide resolved
...core/src/main/java/com/starrocks/sql/optimizer/rule/tree/pdagg/AggregatePushDownContext.java
Show resolved
Hide resolved
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 95 / 100 (95.00%) file detail
|
satanson
approved these changes
Oct 24, 2024
Seaven
approved these changes
Oct 25, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
…52288) Signed-off-by: shuming.li <[email protected]> (cherry picked from commit 2aa5425) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregateFunctionRewriter.java # fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/common/AggregatePushDownUtils.java # fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java
Closed
42 tasks
ZiheLiu
pushed a commit
to ZiheLiu/starrocks
that referenced
this pull request
Oct 31, 2024
…tarRocks#52288) Signed-off-by: shuming.li <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…tarRocks#52288) Signed-off-by: shuming.li <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
ignore backport check: 3.3.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
sum/count
aggregate function for a table, we can also supportavg
function to push down below join sinceavg
can be rewritten bysum/count
.But this case cannot work yet.
What I'm doing:
avg(col)
function, push downsum(col)
andcount(col)
below join, and rewrite into`divide(sum, count) after rewrite.Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: