Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support push down avg aggregate function in mv rewrite #52288

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Oct 24, 2024

Why I'm doing:

  • If we have defined sum/count aggregate function for a table, we can also support avg function to push down below join since avg can be rewritten by sum/count.

But this case cannot work yet.

        String mv = String.format("CREATE MATERIALIZED VIEW mv0 REFRESH MANUAL as " +
                "select LO_ORDERDATE, sum(LO_REVENUE) as revenue_sum, count(LO_REVENUE) as revenue_cnt,\n" +
                " sum(lo_custkey) as sum_lo_custkey, count(lo_custkey) as count_lo_custkey\n" +
                "from lineorder l group by LO_ORDERDATE");
        starRocksAssert.withMaterializedView(mv, () -> {
            String query = String.format("select LO_ORDERDATE, sum(LO_REVENUE), avg(LO_REVENUE) as avg1, " +
                    "avg(LO_REVENUE) as avg2, avg(lo_custkey) as avg3 from lineorder l \n" +
                    "join dates d on l.LO_ORDERDATE = d.d_datekey group by LO_ORDERDATE");
            sql(query).contains("mv0");
        });

What I'm doing:

  • For avg(col) function, push down sum(col) and count(col) below join, and rewrite into`divide(sum, count) after rewrite.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing requested a review from a team as a code owner October 24, 2024 08:16
@github-actions github-actions bot added the 3.3 label Oct 24, 2024
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 95 / 100 (95.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/common/AggregatePushDownUtils.java 65 70 92.86% [117, 126, 211, 212, 213]
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/AggregateFunctionRewriter.java 5 5 100.00% []
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewPushDownRewriter.java 2 2 100.00% []
🔵 com/starrocks/sql/optimizer/rule/tree/pdagg/AggregatePushDownContext.java 23 23 100.00% []

@LiShuMing LiShuMing merged commit 2aa5425 into StarRocks:main Oct 25, 2024
66 of 69 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_mv_push_down_mv branch October 25, 2024 07:37
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 25, 2024
Copy link
Contributor

mergify bot commented Oct 25, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 25, 2024
…52288)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit 2aa5425)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregateFunctionRewriter.java
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/common/AggregatePushDownUtils.java
#	fe/fe-core/src/test/java/com/starrocks/planner/MaterializedViewTest.java
ZiheLiu pushed a commit to ZiheLiu/starrocks that referenced this pull request Oct 31, 2024
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
@wangsimo0
Copy link
Contributor

ignore backport check: 3.3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants