Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix character set issues of string literal in jdbc #51177

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ShaoxunLi
Copy link
Contributor

@ShaoxunLi ShaoxunLi commented Sep 19, 2024

Why I'm doing:

fix character set issues of string literal in jdbc

image

image

What I'm doing:

using uft8 encoding when parse string parameter

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@ShaoxunLi ShaoxunLi requested a review from a team as a code owner September 19, 2024 13:55
@github-actions github-actions bot added the 3.3 label Sep 19, 2024
@ShaoxunLi ShaoxunLi force-pushed the string_literal_parse_param_utf8 branch from 993b1be to 6fd34c4 Compare September 19, 2024 14:19
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/analysis/StringLiteral.java 1 1 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@trueeyu trueeyu merged commit 00444d0 into StarRocks:main Sep 20, 2024
47 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2024
@wangsimo0
Copy link
Contributor

ignore backport check: 3.3.5

renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants