-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] Cached fragment misuses exogenous runtime filter #51150
Merged
stdpain
merged 1 commit into
main
from
Cached_fragment_misuses_exogenous_runtime_filter
Sep 20, 2024
Merged
[BugFix] Cached fragment misuses exogenous runtime filter #51150
stdpain
merged 1 commit into
main
from
Cached_fragment_misuses_exogenous_runtime_filter
Sep 20, 2024
+52
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZiheLiu
previously approved these changes
Sep 19, 2024
satanson
force-pushed
the
Cached_fragment_misuses_exogenous_runtime_filter
branch
3 times, most recently
from
September 19, 2024 09:19
01dd999
to
1014350
Compare
Signed-off-by: satanson <[email protected]>
satanson
force-pushed
the
Cached_fragment_misuses_exogenous_runtime_filter
branch
from
September 19, 2024 10:47
1014350
to
fa710a5
Compare
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 27 / 27 (100.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
stdpain
approved these changes
Sep 20, 2024
LiShuMing
approved these changes
Sep 20, 2024
stdpain
deleted the
Cached_fragment_misuses_exogenous_runtime_filter
branch
September 20, 2024 06:16
@Mergifyio backport branch-3.3 |
@Mergifyio backport branch-3.2 |
@Mergifyio backport branch-3.1 |
@Mergifyio backport branch-3.0 |
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: satanson <[email protected]> (cherry picked from commit 427d13b)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: satanson <[email protected]> (cherry picked from commit 427d13b)
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: satanson <[email protected]> (cherry picked from commit 427d13b) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/planner/PlanFragment.java # fe/fe-core/src/main/java/com/starrocks/qe/DefaultCoordinator.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: satanson <[email protected]> (cherry picked from commit 427d13b) # Conflicts: # fe/fe-core/src/main/java/com/starrocks/planner/PlanFragment.java # fe/fe-core/src/main/java/com/starrocks/qe/DefaultCoordinator.java # fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
42 tasks
This was referenced Sep 20, 2024
satanson
added a commit
to satanson/starrocks
that referenced
this pull request
Sep 20, 2024
…arRocks#51150) Signed-off-by: satanson <[email protected]>
satanson
added a commit
to satanson/starrocks
that referenced
this pull request
Sep 20, 2024
…arRocks#51150) Signed-off-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…51150) (#51198) Co-authored-by: satanson <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…51150) (#51199) Co-authored-by: satanson <[email protected]>
ZiheLiu
pushed a commit
that referenced
this pull request
Sep 20, 2024
…1150) (#51210) Signed-off-by: satanson <[email protected]>
satanson
added a commit
to satanson/starrocks
that referenced
this pull request
Sep 23, 2024
…arRocks#51150) Signed-off-by: satanson <[email protected]>
ZiheLiu
pushed a commit
that referenced
this pull request
Sep 23, 2024
…1150) (#51211) Signed-off-by: satanson <[email protected]>
smartlxh
pushed a commit
to smartlxh/starrocks
that referenced
this pull request
Oct 16, 2024
…backport StarRocks#51150) (StarRocks#51198) 本次代码评审主要涉及优化和重构,包括在多个类中添加新导入、改进运行时过滤器的收集逻辑、调整数据结构以使用HashMap、以及增强PlanFragment的节点收集方法,同时调整了FragmentNormalizer的逻辑,整体提高了代码的结构清晰度和运行时过滤器处理的效率。 Link: https://code.alibaba-inc.com/soe/starrocks/codereview/18493054 * [Backport][BugFix] Cached fragment misuses exogenous runtime filter (backport StarRocks#51150) (StarRocks#51198) Co-authored-by: satanson <[email protected]>
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…51150) Signed-off-by: satanson <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Cached fragment(Fragment 0) should not use exogenous runtime filters produced by remote fragment(Fragment 2's HashJoin(2) ), since the HashJoin(2)'s runtime filter changes as its the right side changes. so we should disable query cache in this situation.
When we take this into conderation , we use PlanFragment.get{Build,Probe}RuntimeFilters methods to obtain fragment-specific runtime filter informations that are not be collected before using.
What I'm doing:
Collection runtime filter build/probe information in PlanFragmentBuilder
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: