Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Cached fragment misuses exogenous runtime filter #51150

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

satanson
Copy link
Contributor

Why I'm doing:

image
Cached fragment(Fragment 0) should not use exogenous runtime filters produced by remote fragment(Fragment 2's HashJoin(2) ), since the HashJoin(2)'s runtime filter changes as its the right side changes. so we should disable query cache in this situation.

When we take this into conderation , we use PlanFragment.get{Build,Probe}RuntimeFilters methods to obtain fragment-specific runtime filter informations that are not be collected before using.

What I'm doing:

Collection runtime filter build/probe information in PlanFragmentBuilder

+        fragments.forEach(PlanFragment::collectBuildRuntimeFilters);
+        fragments.forEach(PlanFragment::collectProbeRuntimeFilters);

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

ZiheLiu
ZiheLiu previously approved these changes Sep 19, 2024
@satanson satanson force-pushed the Cached_fragment_misuses_exogenous_runtime_filter branch 3 times, most recently from 01dd999 to 1014350 Compare September 19, 2024 09:19
@satanson satanson force-pushed the Cached_fragment_misuses_exogenous_runtime_filter branch from 1014350 to fa710a5 Compare September 19, 2024 10:47
Copy link

sonarcloud bot commented Sep 19, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 27 / 27 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/plan/PlanFragmentBuilder.java 2 2 100.00% []
🔵 com/starrocks/planner/FragmentNormalizer.java 5 5 100.00% []
🔵 com/starrocks/planner/PlanFragment.java 20 20 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stdpain stdpain merged commit 427d13b into main Sep 20, 2024
50 checks passed
@stdpain stdpain deleted the Cached_fragment_misuses_exogenous_runtime_filter branch September 20, 2024 06:16
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Sep 20, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Sep 20, 2024
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Sep 20, 2024
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Sep 20, 2024
Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.1

✅ Backports have been created

Copy link
Contributor

mergify bot commented Sep 20, 2024

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 20, 2024
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: satanson <[email protected]>
(cherry picked from commit 427d13b)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/planner/PlanFragment.java
#	fe/fe-core/src/main/java/com/starrocks/qe/DefaultCoordinator.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: satanson <[email protected]>
(cherry picked from commit 427d13b)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/planner/PlanFragment.java
#	fe/fe-core/src/main/java/com/starrocks/qe/DefaultCoordinator.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayFromDumpTest.java
satanson added a commit to satanson/starrocks that referenced this pull request Sep 20, 2024
satanson added a commit to satanson/starrocks that referenced this pull request Sep 20, 2024
ZiheLiu pushed a commit that referenced this pull request Sep 20, 2024
satanson added a commit to satanson/starrocks that referenced this pull request Sep 23, 2024
ZiheLiu pushed a commit that referenced this pull request Sep 23, 2024
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Oct 16, 2024
…backport StarRocks#51150) (StarRocks#51198)

本次代码评审主要涉及优化和重构,包括在多个类中添加新导入、改进运行时过滤器的收集逻辑、调整数据结构以使用HashMap、以及增强PlanFragment的节点收集方法,同时调整了FragmentNormalizer的逻辑,整体提高了代码的结构清晰度和运行时过滤器处理的效率。
Link: https://code.alibaba-inc.com/soe/starrocks/codereview/18493054
* [Backport][BugFix] Cached fragment misuses exogenous runtime filter (backport StarRocks#51150) (StarRocks#51198)

Co-authored-by: satanson <[email protected]>
renzhimin7 pushed a commit to renzhimin7/starrocks that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants