-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement][FlatJson] Improve flat json performace and extract strategy #50696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seaven
force-pushed
the
json
branch
6 times, most recently
from
September 11, 2024 09:34
108cf76
to
5a7237f
Compare
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Signed-off-by: Seaven <[email protected]>
Quality Gate passedIssues Measures |
[BE Incremental Coverage Report]❌ fail : 229 / 301 (76.08%) file detail
|
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]✅ pass : 3 / 3 (100.00%) file detail
|
kangkaisen
approved these changes
Sep 19, 2024
dirtysalt
approved these changes
Sep 19, 2024
stdpain
approved these changes
Sep 20, 2024
meegoo
approved these changes
Sep 20, 2024
HangyuanLiu
approved these changes
Sep 20, 2024
@Mergifyio backport branch-3.3 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 20, 2024
…tegy (#50696) Signed-off-by: Seaven <[email protected]> (cherry picked from commit 45d72ac) # Conflicts: # be/src/exec/olap_scan_prepare.cpp
Merged
42 tasks
Seaven
added a commit
that referenced
this pull request
Sep 20, 2024
…tegy (#50696) Signed-off-by: Seaven <[email protected]> (cherry picked from commit 45d72ac)
wanpengfei-git
pushed a commit
that referenced
this pull request
Sep 20, 2024
…tegy (backport #50696) (#51215) Co-authored-by: Seaven <[email protected]>
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 23, 2024
…act strategy (StarRocks#50696)" This reverts commit 45d72ac.
ZiheLiu
added a commit
to ZiheLiu/starrocks
that referenced
this pull request
Sep 23, 2024
…act strategy (StarRocks#50696)" This reverts commit 45d72ac.
renzhimin7
pushed a commit
to renzhimin7/starrocks
that referenced
this pull request
Nov 7, 2024
…tegy (StarRocks#50696) Signed-off-by: Seaven <[email protected]> Signed-off-by: zhiminr.ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Performance:
FlatJson Extract Strategy:
_finalize
method by bottom-up dfs: for support check non-leaf node and extract itPorfile Enhancement:
flat_json_meta
on primary key tableflat_json_meta
on array/struct/map columnBugFixs:
.
bug: will effect extract subfield name, don't extract when name contains.
What I'm doing:
Fixes https://github.com/StarRocks/StarRocksTest/issues/8533 https://github.com/StarRocks/StarRocksTest/issues/8534 https://github.com/StarRocks/StarRocksTest/issues/8536 https://github.com/StarRocks/StarRocksTest/issues/8568
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: