Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The maxUnavailablePods field in values.yaml does not work #615

Closed
yandongxiao opened this issue Jan 17, 2025 · 0 comments · Fixed by #616
Closed

The maxUnavailablePods field in values.yaml does not work #615

yandongxiao opened this issue Jan 17, 2025 · 0 comments · Fixed by #616
Labels
bug Something isn't working

Comments

@yandongxiao
Copy link
Collaborator

Describe the bug

We have added the following flag to api server

- --feature-gates=MaxUnavailableStatefulSet=true

When we added the field in values.yaml

  # Max unavailable pods for the cn component when doing rolling update.
  # This field cannot be 0. The default setting is 1.
  # Note: Because Operator uses statefulset to manage this component, the maxUnavailable field is in Alpha stage, and it is honored
  # only by API servers that are running with the MaxUnavailableStatefulSet feature gate enabled.
  # See https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#maximum-unavailable-pods for more details.
  maxUnavailablePods:

After upgarding helm chart, the statefulset spec doesn't contain .spec.updateStrategy.rollingUpdate.maxUnavailable field

  updateStrategy:
    type: RollingUpdate
    rollingUpdate:
      partition: 0

Expected behavior

the statefulset spec should have update in updateStrategy fields.

Please complete the following information

  • Operator Version: v1.9.10
  • Chart Name: kube-starrocks
  • Chart Version v1.9.10
@yandongxiao yandongxiao added the bug Something isn't working label Jan 17, 2025
@yandongxiao yandongxiao changed the title maxUnavailablePods field in values.yaml does not work The maxUnavailablePods field in values.yaml does not work Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant