Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support .spec.updateStrategy.rollingUpdate.maxUnavailable in CRD #592

Open
mingmxu opened this issue Nov 5, 2024 · 2 comments
Open

support .spec.updateStrategy.rollingUpdate.maxUnavailable in CRD #592

mingmxu opened this issue Nov 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@mingmxu
Copy link
Contributor

mingmxu commented Nov 5, 2024

Describe the current behavior

Currently both BE and FE StatefulSets use the default Maximum unavailable Pods configuration. A rollout could last for long time as it's deployed pod-by-pod.

Describe the enhancement

By exposing the field, application owner could opt to accelerate the rollout. For example it's safe to set 2 when tablet_replica=3. Or it can be set to the same as BE pod replicas to a super-fast rollout.

Additional context

See https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/#maximum-unavailable-pods for the usage.

@mingmxu mingmxu added the enhancement New feature or request label Nov 5, 2024
@mingmxu
Copy link
Contributor Author

mingmxu commented Nov 5, 2024

cc @yandongxiao

@yandongxiao
Copy link
Collaborator

this feature is LGTM, I think we can support it. @kevincai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants