Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseEmulator Module #42

Open
1 task done
Supereg opened this issue Aug 28, 2024 · 0 comments
Open
1 task done

FirebaseEmulator Module #42

Supereg opened this issue Aug 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Supereg
Copy link
Member

Supereg commented Aug 28, 2024

Problem

Currently, each Firebase module (e.g., Account, Storage, Firestore) has their own way of passing emulator configuration. This often times makes the configuration section pretty verbose, if you conditionally configure the emulator settings. This could also introduce errors as you have to ensure that you pass the same options in both cases.

This problem was first discussed in #39 (comment)

Solution

Provide a dedicated FirebaseEmulator module that receive the emulator configurations for all Firebase emulators. This can be configured in a single if statement in the configuration of the SpeziAppDelegate. All Firebase modules can create a dependency to this DefaultInitializable module to retrieve the emulator configuration.

Additional context

We could keep the existing initializers and mark them deprecated or just remove them as part of a breaking change with the upcoming 2.0 release.

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@Supereg Supereg added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant