Skip to content

Commit d2f123b

Browse files
authored
Resolves the multiple emit from dougmoscrop#280 (dougmoscrop#286)
* Redid the integration tests using serverless-offline * Split offline and AWS editions of the integration tests * Run integration test in Github * Integration needs "npm run" * Re-enable node14.x tests * Demo the pino case doing double logging * Resolves the multiple emit from dougmoscrop#280
1 parent bbba01e commit d2f123b

File tree

11 files changed

+849
-192
lines changed

11 files changed

+849
-192
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,4 +15,5 @@ jobs:
1515
with:
1616
node-version: 18
1717
- run: npm ci
18-
- run: npm test
18+
- run: npm test
19+
- run: npm run test:integration:offline

lib/response.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,6 @@ module.exports = class ServerlessResponse extends http.ServerResponse {
127127
return true;
128128
},
129129
});
130-
131-
this.once('finish', () => {
132-
this.emit('close')
133-
});
134130
}
135131

136132
};

0 commit comments

Comments
 (0)