Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the /paths from absolute to relative in HTML #5

Open
arm4b opened this issue Aug 1, 2022 · 0 comments · May be fixed by #10
Open

Fix the /paths from absolute to relative in HTML #5

arm4b opened this issue Aug 1, 2022 · 0 comments · May be fixed by #10
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@arm4b
Copy link
Member

arm4b commented Aug 1, 2022

If someone tries to clone the repo and work with it as GH static pages or local preview the website might not render properly if served from the subdir, missing the images, js, and, css (404). That's because the static content is served based on / absolute path instead of relative.

Someone needs to go through the pages and fix the paths to static content so it works properly even if the website is served from the subdirectory like github-static-pages.com/stackstorm.com/.

Example https://github.com/StackStorm/stackstorm.com/blob/main/index.html:

-	<link rel="stylesheet" id="dashicons-css" href="/wp/wp-includes/css/dashicons.min.css?ver=09e48cfb58fec140b4ee0c6d1d4da1b2" type="text/css" media="all">
+	<link rel="stylesheet" id="dashicons-css" href="wp/wp-includes/css/dashicons.min.css?ver=09e48cfb58fec140b4ee0c6d1d4da1b2" type="text/css" media="all">

Keep in mind the paths for stackstorm.com vs https://stackstorm.com/2022/05/10/stackstorm-3-7-0-released/ pages mgiht need different modifications.

@arm4b arm4b added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant