Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails on 3rd party Forked PRs #47

Open
arm4b opened this issue Jul 7, 2016 · 0 comments
Open

Build fails on 3rd party Forked PRs #47

arm4b opened this issue Jul 7, 2016 · 0 comments
Labels

Comments

@arm4b
Copy link
Member

arm4b commented Jul 7, 2016

Example: https://circleci.com/gh/StackStorm/st2chatops/253

This happens because of several reasons:

  • Build assumes that HUBOT_SLACK_TOKEN is provided
  • Build assumes that PACKAGECLOUD_TOKEN is provided

For security reasons these env variables are hidden https://circleci.com/docs/fork-pr-builds/#security-implications-of-running-builds-for-pull-requests-from-forks for forked builds.
But it's possible to make some steps optional which require envs. For example HUBOT_SLACK_TOKEN is not needed for the PR builds.

For the moment it means it's hardly possible to accept 3rd party contributions.

arm4b pushed a commit to arm4b/st2chatops that referenced this issue Jul 7, 2016
Avoid failing the build, because PACKAGECLOUD_TOKEN is not available
Partially solves StackStorm#47
arm4b pushed a commit to arm4b/st2chatops that referenced this issue Jul 7, 2016
Avoid failing the build, because PACKAGECLOUD_TOKEN is not available
Partially solves StackStorm#47
@arm4b arm4b added the bug label Feb 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant