Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVIDIA 572.16 driver added RExt support in DXVA decoder & video processor #92

Open
nyanmisaka opened this issue Jan 30, 2025 · 2 comments

Comments

@nyanmisaka
Copy link

As i requested in nvpro-samples/vk_video_samples#98, they implemented it in the latest 572.16 Windows driver. Including these new GUIDs and video processors support. Maybe the newly released RTX 50 series will have extra support for RExt 422 formats.

DEFINE_GUID(DXVA_ModeHEVC_VLD_Main12, 0x1a72925f, 0x0c2c, 0x4f15, 0x96, 0xfb, 0xb1, 0x7d, 0x14, 0x73, 0x60, 0x3f);
DEFINE_GUID(DXVA_ModeHEVC_VLD_Main_444, 0x4008018f, 0xf537, 0x4b36, 0x98, 0xcf, 0x61, 0xaf, 0x8a, 0x2c, 0x1a, 0x33);
DEFINE_GUID(DXVA_ModeHEVC_VLD_Main10_444, 0x0dabeffa, 0x4458, 0x4602, 0xbc, 0x03, 0x07, 0x95, 0x65, 0x9d, 0x61, 0x7c);
DEFINE_GUID(DXVA_ModeHEVC_VLD_Main12_444, 0x9798634d, 0xfe9d, 0x48e5, 0xb4, 0xda, 0xdb, 0xec, 0x45, 0xb3, 0xdf, 0x01);

But the Main12 GUID still only allows P010, which i think it should be P012/P016, just like on Intel GPUs.

Image
Image
Image

@StaZhu
Copy link
Owner

StaZhu commented Jan 30, 2025

Thanks, that’s good news to see Nvidia finally add those 8bit/10bit/12bit 4:4:4 profiles and implement ed VP support for the old GPUs too!

@taste1981 and I are still waiting for Chromium infra teams to upgrade Windows SDK to 10.0.26001, once the SDK is updated, we will submit code to chromium repo and add 8/10/12bit 4:2:0/4:2:2/4:4:4 new GUIDs to the chromium repo.

But the Main12 GUID still only allows P010, which i think it should be P012/P016, just like on Intel GPUs.

Technically, this is not an issue for Chromium implementations, Chromium did only choose P010 as output format for P016 input (https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/windows/d3d11_texture_selector.cc;l=156), Its hard to say if the media team want us to add P016 format in the future.

@nyanmisaka
Copy link
Author

@taste1981 and I are still waiting for Chromium infra teams to upgrade Windows SDK to 10.0.26001, once the SDK is updated, we will submit code to chromium repo and add 8/10/12bit 4:2:0/4:2:2/4:4:4 new GUIDs to the chromium repo.

Nice to see that. Will Intel also switch to these new GUIDs, which would presumably mean the end of Ice Lake support (driver support is EOL long times ago) ?

Technically, this is not an issue for Chromium implementations, Chromium did only choose P010 as output format for P016 input (https://source.chromium.org/chromium/chromium/src/+/main:media/gpu/windows/d3d11_texture_selector.cc;l=156), Its hard to say if the media team want us to add P016 format in the future.

Yep. I also doubt that the human eye can tell the difference between >= 10bit depth pixel formats. It should just be a conformance issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants