Update checkstyle and fix style issues (#2237)

Author: ImMorpheus

checkstyle-suppressions.xml

@@ -1,25 +1,20 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE suppressions PUBLIC
-        "-//Puppy Crawl//DTD Suppressions 1.2//EN"
-        "http://checkstyle.sourceforge.net/dtds/suppressions_1_2.dtd">
+        "-//Checkstyle//DTD SuppressionFilter Configuration 1.2//EN"
+        "https://checkstyle.org/dtds/suppressions_1_2.dtd">
 
 <suppressions>
-    <suppress checks="JavadocMethod|SummaryJavadoc|AvoidEscapedUnicodeCharacters" files="src[\\/]test[\\/]java[\\/].*"/>
-    <suppress checks="Indentation" files="package-info\.java"/>
-    <suppress checks="AbbreviationAsWordInName" files="AI"/>
-    <suppress checks="AbbreviationAsWordInName" files="TNT"/>
-    <suppress checks="AbbreviationAsWordInName" files="PVP"/>
-    <suppress checks="AbbreviationAsWordInName" files="PEBKAC"/>
-    <suppress checks="AbbreviationAsWordInName" files="AABB"/>
-    <suppress checks=".*" files="SpongeEventFactory\.java"/>
-    <suppress checks="LineLength" files="IntegerTraits\.java"/>
-    <suppress checks="LineLength" files="BooleanTraits\.java"/>
-    <suppress checks="LineLength" files="SoundTypes\.java"/>
-    <suppress checks="LineLength" files="CraftingRecipes\.java"/>
-    <suppress checks="LineLength" files="QueryTypes\.java"/>
-    <suppress checks="LineLength" files="Keys\.java"/>
-    <suppress checks="LineLength|OneStatementPerLine|WhitespaceAround" files="TypeTokens\.java"/>
-    <suppress checks="AvoidStarImport" files="Keys\.java"/>
-    <suppress checks="AvoidStarImport" files="CatalogEntityData\.java"/>
-    <suppress checks="AvoidStarImport" files="CatalogTypes\.java"/>
+    <suppress checks="LineLength"/>
+    <suppress checks="SummaryJavadoc"/>
+    <suppress checks="MissingJavadocType"/>
+    <suppress checks="MissingJavadocMethod"/>
+    <suppress checks="OverloadMethodsDeclarationOrder"/>
+    <suppress checks="RequireEmptyLineBeforeBlockTagGroup"/>
+    <suppress checks="JavadocParagraph"/>
+    <suppress checks="JavadocTagContinuationIndentation"/>
+    <suppress checks="NonEmptyAtclauseDescription"/>
+    <suppress checks="AbbreviationAsWordInName"/>
+    <suppress checks="MethodTypeParameterName"/>
+    <suppress checks="CommentsIndentation"/>
+    <suppress checks="InterfaceTypeParameterName"/>
 </suppressions>

checkstyle.xml

@@ -24,9 +24,9 @@
  */
 package org.spongepowered.api;
 
+import org.spongepowered.api.client.LocalServer;
 import org.spongepowered.api.entity.living.player.client.ClientPlayer;
 import org.spongepowered.api.entity.living.player.client.LocalPlayer;
-import org.spongepowered.api.client.LocalServer;
 import org.spongepowered.api.network.ClientSideConnection;
 import org.spongepowered.api.world.client.ClientWorld;
 

extra/ideal-checkstyle.xml

@@ -35,6 +35,7 @@ public interface Engine extends ScopedRegistryHolder {
 
     /**
      * Gets the {@link Game} that launched this engine;
+     *
      * @return The game
      */
     Game game();

src/main/java/org/spongepowered/api/Client.java

@@ -39,9 +39,9 @@
 import org.spongepowered.api.registry.RegistryHolder;
 import org.spongepowered.api.registry.ScopedRegistryHolder;
 import org.spongepowered.api.scheduler.Scheduler;
+import org.spongepowered.api.service.ServiceProvider;
 import org.spongepowered.api.sql.SqlManager;
 import org.spongepowered.api.util.metric.MetricsConfigManager;
-import org.spongepowered.api.service.ServiceProvider;
 
 import java.nio.file.Path;
 import java.util.Locale;

src/main/java/org/spongepowered/api/Engine.java

@@ -33,18 +33,18 @@
 import org.spongepowered.api.entity.living.animal.Animal;
 import org.spongepowered.api.entity.living.player.gamemode.GameMode;
 import org.spongepowered.api.entity.living.player.server.ServerPlayer;
-import org.spongepowered.api.map.MapStorage;
 import org.spongepowered.api.event.lifecycle.RegisterCommandEvent;
+import org.spongepowered.api.map.MapStorage;
 import org.spongepowered.api.network.ServerSideConnection;
 import org.spongepowered.api.profile.GameProfileManager;
 import org.spongepowered.api.resourcepack.ResourcePack;
 import org.spongepowered.api.scoreboard.Scoreboard;
 import org.spongepowered.api.service.ServiceProvider;
 import org.spongepowered.api.user.UserManager;
 import org.spongepowered.api.util.locale.LocaleSource;
-import org.spongepowered.api.world.server.ServerLocation;
 import org.spongepowered.api.world.difficulty.Difficulty;
 import org.spongepowered.api.world.generation.config.WorldGenerationConfig;
+import org.spongepowered.api.world.server.ServerLocation;
 import org.spongepowered.api.world.server.ServerWorld;
 import org.spongepowered.api.world.server.WorldManager;
 import org.spongepowered.api.world.storage.ChunkLayout;

src/main/java/org/spongepowered/api/Game.java

@@ -29,9 +29,9 @@
  */
 public class UnsupportedEngineException extends UnsupportedOperationException {
 
-  private static final long serialVersionUID = 5671217624171369435L;
+    private static final long serialVersionUID = 5671217624171369435L;
 
-  public UnsupportedEngineException(final String message) {
-    super(message);
-  }
+    public UnsupportedEngineException(final String message) {
+        super(message);
+    }
 }

src/main/java/org/spongepowered/api/Server.java

@@ -28,9 +28,9 @@
 import net.kyori.adventure.text.ComponentLike;
 import org.checkerframework.checker.nullness.qual.Nullable;
 import org.spongepowered.api.ResourceKey;
-import org.spongepowered.api.datapack.DataPackSerializable;
 import org.spongepowered.api.Sponge;
 import org.spongepowered.api.advancement.criteria.AdvancementCriterion;
+import org.spongepowered.api.datapack.DataPackSerializable;
 import org.spongepowered.api.util.ResourceKeyedBuilder;
 
 import java.util.Collection;