Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review unused public API #11

Open
armiol opened this issue Dec 6, 2021 · 0 comments
Open

Review unused public API #11

armiol opened this issue Dec 6, 2021 · 0 comments
Labels
tech. debt What makes us slow in dev?

Comments

@armiol
Copy link
Contributor

armiol commented Dec 6, 2021

As tool-base is a set of modules, used by various Spine tooling, it exposes a big list of public types and methods.

Currently, some of them are detected as "unused". This is probably because they were used in tests of base repository — before they got extracted into this repo.

To avoid warnings — and to prevent someone accidentally killing the "unused" API elements — I have marked all of them as

@SuppressWarnings("unused") /* Part of the public API. */

And while this is true for most of the API endpoints, it may be false for some of them — and the latter really need to be killed.

In scope of this issue, the public API should be revised and "stripped-to-fit".

@alexander-yevsyukov alexander-yevsyukov added the tech. debt What makes us slow in dev? label Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech. debt What makes us slow in dev?
Projects
None yet
Development

No branches or pull requests

2 participants