You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But still there is a place for other improvements:
Snippet.value() should return an immutable result. Now, it returns mutable CodeLines.
CodeLines should not contain methods to compose code (enterMethod, enterBlock etc). Instead, such a functionality should be implemented by inheriting CodeLine (see RawLine) or by implementing Snippet (see Method).
Remove JsCodeGenerators and use Snippet instead.
The text was updated successfully, but these errors were encountered:
The code for the generation of Javascript was improved in SpineEventEngine/base#255.
But still there is a place for other improvements:
Snippet.value()
should return an immutable result. Now, it returns mutableCodeLines
.CodeLines
should not contain methods to compose code (enterMethod
,enterBlock
etc). Instead, such a functionality should be implemented by inheritingCodeLine
(seeRawLine
) or by implementingSnippet
(seeMethod
).JsCodeGenerator
s and useSnippet
instead.The text was updated successfully, but these errors were encountered: