Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the code for the generation of Javascript code #8

Open
dmytro-grankin opened this issue Dec 20, 2018 · 0 comments
Open

Improve the code for the generation of Javascript code #8

dmytro-grankin opened this issue Dec 20, 2018 · 0 comments

Comments

@dmytro-grankin
Copy link

dmytro-grankin commented Dec 20, 2018

The code for the generation of Javascript was improved in SpineEventEngine/base#255.

But still there is a place for other improvements:

  • Snippet.value() should return an immutable result. Now, it returns mutable CodeLines.
  • CodeLines should not contain methods to compose code (enterMethod, enterBlock etc). Instead, such a functionality should be implemented by inheriting CodeLine (see RawLine) or by implementing Snippet (see Method).
  • Remove JsCodeGenerators and use Snippet instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant