Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate id() method for EntityState types #114

Open
alexander-yevsyukov opened this issue Dec 8, 2022 · 0 comments
Open

Generate id() method for EntityState types #114

alexander-yevsyukov opened this issue Dec 8, 2022 · 0 comments

Comments

@alexander-yevsyukov
Copy link
Contributor

The EntityState interface defined in base has a generic parameter <I> but this parameter is not used in the interface (which is empty). We have a lengthy description of the convention for the first message field and so on, but it does not make it less confusing, “Why the generic parameter is not used in the interface?”

Obviously, having the id() method returning I would make it more obviously. But we need to tune ProtoData to handle this, and extend the interface accordingly.

@alexander-yevsyukov alexander-yevsyukov transferred this issue from SpineEventEngine/ProtoData Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant