Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having PlatformProvider as a hard Kotlin class #67

Open
yevhenii-nadtochii opened this issue Oct 2, 2023 · 0 comments
Open

Comments

@yevhenii-nadtochii
Copy link
Collaborator

Please try to make PlatformProvider a plain Kotlin class.

Now it is generated during the build by means of ASM library (see :flogger-platform-generator module). This library uses JVM opcodes, and the whole generation looks quite frightening. For me, it is unclear why we should continue to generate it on the fly when we can use a hard class.

In the current set up, this generation seems unnecessary, as there is no way the generated file would somehow differ on different platforms. We always generate the same file.

Another reason for this generation seems to lie in compatibility with proguard tool, and how this tool detects dependencies. This tool is for Android, and I'm not sure if this problem is relevant for newer versions of Android and the mentioned tool. For example, taking Android 6 (September 2015) or 7 (August 2016) as a bottom bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant