You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've extended visibility of the class constructor and the factory method for forcing loggers to protected.
These are needed in tests to create stub implementations. Having them package-private forces to declare stubs right in spec files, which is inconvenient if that stubs are pretty big.
When migrating this class to Kotlin, these methods should become internal because real implementations should not see these methods as open.
The text was updated successfully, but these errors were encountered:
I've extended visibility of the class constructor and the factory method for forcing loggers to
protected
.These are needed in tests to create stub implementations. Having them package-private forces to declare stubs right in spec files, which is inconvenient if that stubs are pretty big.
When migrating this class to Kotlin, these methods should become
internal
because real implementations should not see these methods asopen
.The text was updated successfully, but these errors were encountered: