Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Go] Refactor the entrypoint and cli packages #46

Closed
olena-zmiiova opened this issue Sep 5, 2024 · 1 comment
Closed

[Go] Refactor the entrypoint and cli packages #46

olena-zmiiova opened this issue Sep 5, 2024 · 1 comment
Assignees

Comments

@olena-zmiiova
Copy link

olena-zmiiova commented Sep 5, 2024

Linked issue: #43

The cli packages has a validation for arguments received from the entrypoint, so they should be refactored in one scope:

  1. The args validation code should be easier to read and understand.
  2. Remained cyclop linter issues should be resolved.
  3. Reconsider the naming of arguments.
  4. Add logging.
  5. Add output to a user after a successful run.
  6. Improve error processing.
  7. Recheck & update documentation.
  8. Update UTs, checking if they can be improved with gomega and ginkgo libs.
@olena-zmiiova olena-zmiiova self-assigned this Sep 5, 2024
@olena-zmiiova
Copy link
Author

PRs are merged #49, #50, closing an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant