Skip to content

Add lacking custom Protobuf options for enum #69

Open
@dmytro-grankin

Description

@dmytro-grankin

Protobuf separates options for messages — google.protobuf.MessageOptions and for enums — google.protobuf.EnumOptions.

The framework defines custom options for messages, but there are no defined options for enums.

E.g. beta_type, experimental_type, internal_type, SPI_type options also make sense for enums. Java classes generated from messages with the options will additionally have corresponding annotations. ProtoAnnotatorPlugin does this work. Since new options will be added for enums, ProtoAnnotatorPlugin should be updated either to add annotations for enums.

EnumAnnotator already exists, so only a task for ProtoAnnotatorPlugin should be changed to use EnumAnnotator.

Besides the mentioned options, other custom options for messages should be reviewed and added for enums if it makes sense.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions