You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Protobuf separates options for messages — google.protobuf.MessageOptions and for enums — google.protobuf.EnumOptions.
The framework defines custom options for messages, but there are no defined options for enums.
E.g. beta_type, experimental_type, internal_type, SPI_type options also make sense for enums. Java classes generated from messages with the options will additionally have corresponding annotations. ProtoAnnotatorPlugin does this work. Since new options will be added for enums, ProtoAnnotatorPlugin should be updated either to add annotations for enums.
EnumAnnotator already exists, so only a task for ProtoAnnotatorPlugin should be changed to use EnumAnnotator.
Besides the mentioned options, other custom options for messages should be reviewed and added for enums if it makes sense.
The text was updated successfully, but these errors were encountered:
I've removed the bug label because until now we have not experienced the need for enum options marking them as internal, for example.
In the light of internal type filtering, we filter by message types, not by enum types. We cannot send an enum. Thus, having such options may be a thing for purists, but it's not a priority for the scope of 2.0.
Protobuf separates options for messages —
google.protobuf.MessageOptions
and for enums —google.protobuf.EnumOptions
.The framework defines custom options for messages, but there are no defined options for enums.
E.g.
beta_type
,experimental_type
,internal_type
,SPI_type
options also make sense for enums. Java classes generated from messages with the options will additionally have corresponding annotations.ProtoAnnotatorPlugin
does this work. Since new options will be added for enums,ProtoAnnotatorPlugin
should be updated either to add annotations for enums.EnumAnnotator
already exists, so only a task forProtoAnnotatorPlugin
should be changed to useEnumAnnotator
.Besides the mentioned options, other custom options for messages should be reviewed and added for enums if it makes sense.
The text was updated successfully, but these errors were encountered: