You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to open a pull request. In preparation I had a look on CONTRIBUTING.md which sent me to the Wiki on Contributing.
I followed the requirements, e.g. ensured the commit is signed, pushed the commit to my fork, then attempted to open a new PR.
In the PR template a link to #672 appeared, which contains additional requirements like that an issue for discussion is mandatory before opening a PR.
This is kind of frustrating because it would be better to know that in advance.
I recommend adding every requirement to the Wiki page and link to that from the PR template instead of to the mentioned issue. This makes everything available in one place and is easier to find. I think a random closed issue is not the most appropriate place for this information.
(Additional point of view: The shorter and more condensed the docs on contributing are the better. Long documents might discourage potential contributors.)
Are you intending to fix this bug?
No
Component(s) Affected:
Documentation
Contributor Checklist:
I have searched the issue tracker to ensure this bug hasn't been reported before or is not already being addressed.
I have provided clear steps to reproduce the issue.
I have included relevant environment information details.
I have attached necessary supporting documents.
I have checked that any JSON files I am attempting to upload to BloodHound are valid.
The text was updated successfully, but these errors were encountered:
Description:
I wanted to open a pull request. In preparation I had a look on CONTRIBUTING.md which sent me to the Wiki on Contributing.
I followed the requirements, e.g. ensured the commit is signed, pushed the commit to my fork, then attempted to open a new PR.
In the PR template a link to #672 appeared, which contains additional requirements like that an issue for discussion is mandatory before opening a PR.
This is kind of frustrating because it would be better to know that in advance.
I recommend adding every requirement to the Wiki page and link to that from the PR template instead of to the mentioned issue. This makes everything available in one place and is easier to find. I think a random closed issue is not the most appropriate place for this information.
(Additional point of view: The shorter and more condensed the docs on contributing are the better. Long documents might discourage potential contributors.)
Are you intending to fix this bug?
No
Component(s) Affected:
Contributor Checklist:
The text was updated successfully, but these errors were encountered: