Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle missing in the repo #16

Open
Vectrobe opened this issue May 1, 2018 · 4 comments
Open

Gradle missing in the repo #16

Vectrobe opened this issue May 1, 2018 · 4 comments
Assignees

Comments

@Vectrobe
Copy link

Vectrobe commented May 1, 2018

This is actually rather important to have, as it keeps building between clones consistent, as well as being a one-touch setup, the files and folders to push are as follows;

  • build.gradle (this is the build config file, you cant do anything without it)
  • gradlew
  • gradlew.bat (windows wrapper)
  • gradle/wrapper folder (this contains the current gradle version config and active version)

With these files included in the repo correctly, all a contributor needs to do is clone > run 'gradlew setupDecompWorkspace idea' and everything will be automatically downloaded, including forge itself.

@kmcnaught kmcnaught self-assigned this May 1, 2018
@kmcnaught
Copy link
Collaborator

Thanks for spotting this, I'll try to fix it today

@kmcnaught
Copy link
Collaborator

Hi Paul,

With the current setup, you just need to download the forge source which already has the standard gradle files, and point the src/main directory to the cloned repo, as described in the top level readme (I just now updated a couple of references to an older forge version, but it should work). I haven't customised the forge gradle scripts/setup at all. I agree it would be nicer if forge was downloaded automatically for a one-touch build, but I guess this makes it harder to switch between forge versions during development, and generally requires a different structure to how the repo is currently set up, so I'll leave this issue open to think about :)

@Vectrobe
Copy link
Author

Vectrobe commented May 1, 2018

if you need to use different forge versions, you need to make different github branches, or just update the version in the build file.

build.gradle contains the forge version to download and use, change the value and it should automatically update on the next build.

@Vectrobe
Copy link
Author

Vectrobe commented May 2, 2018

by the way; everything in the python scripts already exists in gradle, everything is scriptable via gradle's own build script system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants