Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting errors in flow with generics #2458

Closed
Lythenas opened this issue Jan 14, 2019 · 5 comments
Closed

Syntax Highlighting errors in flow with generics #2458

Lythenas opened this issue Jan 14, 2019 · 5 comments
Labels
bug-upstream bug of upstream plugins for vim/neovim
Milestone

Comments

@Lythenas
Copy link

Expected behavior, english is required

Highlight this code correctly:

type Test2<A> = A;
type Test = Test2<{}>;
type Test3 = string;

The reproduce ways from Vim starting (Required!)

Open a .js file containing the code above. The first two lines are highlighted correctly (as far as I can tell). But the third line ist not highlighted at all. And everything after that is also not highlighted correctly.

Debug info

SpaceVim layers:

- VersionControl:       not loaded          https://spacevim.org/layers/VersionControl/
+ autocomplete:             loaded          https://spacevim.org/layers/autocomplete/
- chat:                 not loaded          https://spacevim.org/layers/chat/
+ checkers:                 loaded          https://spacevim.org/layers/checkers/
- chinese:              not loaded          https://spacevim.org/layers/chinese/
+ colorscheme:              loaded          https://spacevim.org/layers/colorscheme/
+ core#banner:              loaded          https://spacevim.org/layers/core/banner/
+ core#statusline:          loaded          https://spacevim.org/layers/core/statusline/
+ core#tabline:             loaded          https://spacevim.org/layers/core/tabline/
+ core:                     loaded          https://spacevim.org/layers/core/
- cscope:               not loaded          https://spacevim.org/layers/cscope/
- ctrlp:                not loaded          https://spacevim.org/layers/ctrlp/
- debug:                not loaded          https://spacevim.org/layers/debug/
+ denite:                   loaded          https://spacevim.org/layers/denite/
+ edit:                     loaded          https://spacevim.org/layers/edit/
- exprfold:             not loaded          no exists
- floobits:             not loaded          https://spacevim.org/layers/floobits/
+ format:                   loaded          https://spacevim.org/layers/format/
- fzf:                  not loaded          https://spacevim.org/layers/fzf/
- games:                not loaded          no exists
+ git:                      loaded          https://spacevim.org/layers/git/
- github:               not loaded          https://spacevim.org/layers/github/
- incsearch:            not loaded          no exists
- indentmove:           not loaded          no exists
- japanese:             not loaded          https://spacevim.org/layers/japanese/
- lang#WebAssembly:     not loaded          https://spacevim.org/layers/lang/WebAssembly/
- lang#agda:            not loaded          https://spacevim.org/layers/lang/agda/
- lang#asciidoc:        not loaded          https://spacevim.org/layers/lang/asciidoc/
- lang#autohotkey:      not loaded          https://spacevim.org/layers/lang/autohotkey/
- lang#c:               not loaded          https://spacevim.org/layers/lang/c/
- lang#clojure:         not loaded          https://spacevim.org/layers/lang/clojure/
- lang#crystal:         not loaded          no exists
- lang#csharp:          not loaded          https://spacevim.org/layers/lang/csharp/
- lang#dart:            not loaded          https://spacevim.org/layers/lang/dart/
+ lang#dockerfile:          loaded          https://spacevim.org/layers/lang/dockerfile/
- lang#elixir:          not loaded          https://spacevim.org/layers/lang/elixir/
- lang#elm:             not loaded          https://spacevim.org/layers/lang/elm/
- lang#erlang:          not loaded          https://spacevim.org/layers/lang/erlang/
+ lang#extra:               loaded          https://spacevim.org/layers/lang/extra/
- lang#fsharp:          not loaded          https://spacevim.org/layers/lang/fsharp/
- lang#go:              not loaded          https://spacevim.org/layers/lang/go/
- lang#graphql:         not loaded          https://spacevim.org/layers/lang/graphql/
+ lang#haskell:             loaded          https://spacevim.org/layers/lang/haskell/
+ lang#html:                loaded          https://spacevim.org/layers/lang/html/
- lang#java:            not loaded          https://spacevim.org/layers/lang/java/
+ lang#javascript:          loaded          https://spacevim.org/layers/lang/javascript/
- lang#json:            not loaded          no exists
- lang#julia:           not loaded          https://spacevim.org/layers/lang/julia/
- lang#kotlin:          not loaded          https://spacevim.org/layers/lang/kotlin/
+ lang#latex:               loaded          https://spacevim.org/layers/lang/latex/
+ lang#lisp:                loaded          https://spacevim.org/layers/lang/lisp/
+ lang#lua:                 loaded          https://spacevim.org/layers/lang/lua/
+ lang#markdown:            loaded          https://spacevim.org/layers/lang/markdown/
- lang#nim:             not loaded          https://spacevim.org/layers/lang/nim/
- lang#ocaml:           not loaded          https://spacevim.org/layers/lang/ocaml/
- lang#perl:            not loaded          https://spacevim.org/layers/lang/perl/
- lang#php:             not loaded          https://spacevim.org/layers/lang/php/
+ lang#plantuml:            loaded          https://spacevim.org/layers/lang/plantuml/
- lang#pony:            not loaded          no exists
- lang#ps1:             not loaded          no exists
- lang#puppet:          not loaded          https://spacevim.org/layers/lang/puppet/
- lang#purescript:      not loaded          https://spacevim.org/layers/lang/purescript/
+ lang#python:              loaded          https://spacevim.org/layers/lang/python/
- lang#r:               not loaded          no exists
- lang#ruby:            not loaded          https://spacevim.org/layers/lang/ruby/
+ lang#rust:                loaded          https://spacevim.org/layers/lang/rust/
- lang#scala:           not loaded          https://spacevim.org/layers/lang/scala/
- lang#scheme:          not loaded          https://spacevim.org/layers/lang/scheme/
+ lang#sh:                  loaded          https://spacevim.org/layers/lang/sh/
- lang#solidity:        not loaded          no exists
- lang#swift:           not loaded          https://spacevim.org/layers/lang/swift/
- lang#swig:            not loaded          no exists
- lang#toml:            not loaded          no exists
+ lang#typescript:          loaded          https://spacevim.org/layers/lang/typescript/
+ lang#vim:                 loaded          https://spacevim.org/layers/lang/vim/
- lang#vue:             not loaded          https://spacevim.org/layers/lang/vue/
- lang#xml:             not loaded          no exists
- leaderf:              not loaded          https://spacevim.org/layers/leaderf/
+ lsp:                      loaded          no exists
- mail:                 not loaded          no exists
- operator:             not loaded          no exists
- org:                  not loaded          no exists
+ shell:                    loaded          https://spacevim.org/layers/shell/
+ sudo:                     loaded          https://spacevim.org/layers/sudo/
- tags:                 not loaded          https://spacevim.org/layers/tags/
- test:                 not loaded          https://spacevim.org/layers/test/
- tmux:                 not loaded          https://spacevim.org/layers/tmux/
- tools#dash:           not loaded          https://spacevim.org/layers/tools/dash/
- tools#screensaver:    not loaded          no exists
+ tools:                    loaded          https://spacevim.org/layers/tools/
+ ui:                       loaded          https://spacevim.org/layers/ui/
- unite:                not loaded          https://spacevim.org/layers/unite/
- vim:                  not loaded          no exists

Screenshots

https://imgur.com/a/GzPBrqD

@ssfdust
Copy link
Contributor

ssfdust commented Jan 15, 2019

It's properly caused by some javascript plugin, but I cannot figure it out. Do you have some advice? I have been living with it for a long time, since I don't care about it.

@Lythenas
Copy link
Author

Lythenas commented Jan 15, 2019

@ssfdust

Do you have some advice? I have been living with it for a long time, since I don't care about it.

For now I'm just disabling flow. Some keywords (like type, any,...) aren't highlighted anymore but as far as I can tell the rest works fine.

Syntax highlighting is still broken in some situations when disabling flow. For now I will just put all my types at the bottom of the files. That mostly fixes the syntax highlighting of the rest of the code.

@Lythenas Lythenas reopened this Jan 17, 2019
@Lythenas
Copy link
Author

It would be helpful if someone could point me to the plugin that takes care of highlighting flow. Then I can open an issue there.

@wsdjeg wsdjeg added the bug-upstream bug of upstream plugins for vim/neovim label Jan 21, 2019
@ssfdust
Copy link
Contributor

ssfdust commented Jan 22, 2019

Sorry, I don't have enough time to help you until sunday.

@wsdjeg
Copy link
Member

wsdjeg commented Jan 27, 2019

I can reproduce it:

flow

It is a bug of https://github.com/flowtype/vim-flow

just report it, flow/vim-flow#81

@wsdjeg wsdjeg closed this as completed Jan 27, 2019
@wsdjeg wsdjeg added this to the v1.1.0 milestone Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-upstream bug of upstream plugins for vim/neovim
Development

No branches or pull requests

3 participants