Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fallback for bootstrap icons in offline mode (or download locally) #1

Open
LuPro opened this issue Aug 5, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request low priority Not immediately important

Comments

@LuPro
Copy link
Contributor

LuPro commented Aug 5, 2021

Probably related to bootstrap being loaded online instead of locally. Fallback when no connection? Download locally?
Googlefonts Montserrat also not available without connection, but that has a viable fallback already (Some Times-like serif font)

@LuPro LuPro self-assigned this Aug 5, 2021
@LuPro LuPro added the high priority needs to be worked soon label Aug 5, 2021
@LuPro
Copy link
Contributor Author

LuPro commented Aug 6, 2021

This is not actually the case, I thought my internet cut out completely when it didn't load but apparently it was just very slow/spotty so it tried loading online resources but took forever. With no connection at all the page loads as expected with only bootstrap icons not loading (as those are online). Functionality still is fine, but a better fall back than having empty buttons would be a good idea (or download the bootstrap icons in use locally)

@LuPro LuPro changed the title PnID doesn't load at all without internet connection Better fallback for bootstrap icons in offline mode (or download locally) Aug 6, 2021
@LuPro LuPro added low priority Not immediately important enhancement New feature or request and removed high priority needs to be worked soon labels Aug 6, 2021
@LuPro
Copy link
Contributor Author

LuPro commented Aug 22, 2021

This is not actually actually the case, jquery was just cached for that test apparently. jquery 3.4.1 was actually downloaded, just not used, so I just changed the online jquery reference on some cdn to the local version and now bootstrap icons really are the last thing loaded online

@markuspinter markuspinter added this to the Must have for coldflow milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Not immediately important
Projects
None yet
Development

No branches or pull requests

2 participants