Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Remove item durability #70

Open
MykalsVapor opened this issue Jul 4, 2023 · 2 comments
Open

[FEATURE]: Remove item durability #70

MykalsVapor opened this issue Jul 4, 2023 · 2 comments
Labels
Enhancement A feature or suggestion Priority: Optional

Comments

@MykalsVapor
Copy link

Is your feature request related to a problem? Please describe.

My axe never depletes durabilty when chopping trees down.

Describe the solution you'd like

I noticed back in 2017 someone else had requested this feature in the comments section of the Spigot page. Items are supposed to take damage as they are used. If you could make it so we could choose a percentage of the durability it would normally remove, that might help everyone. If we choose 100% then the plugin treats it like you chopped up every piece of the tree by hand and removes durability based on the number of WOOD blocks broken. And likewise, if we choose 0%, it wouldn't take away any durability.

Describe alternatives you've considered

alternatively you could copy someone elses working code that does the same thing??? (not sure what im supposed to write here)

Additional Information

appreciate the effort you have already put into this! thank you!

@MykalsVapor MykalsVapor added Enhancement A feature or suggestion Priority: Optional labels Jul 4, 2023
@Lauriichan
Copy link
Member

I don't understand what this issue is supposed to request.
SmoothTimber uses the normal durability mechanics of minecraft. If you break a tree with SmoothTimber you are breaking multiple blocks and each of those blocks will remove one durability of your unenchanted tool. If you enabled unbreaking in your config file (which it is by default) and the tool you are using is enchanted with unbreaking then it will apply the same calculation for durability usage as minecraft does it. Tools will also fully break once their durability is up. We don't have anything in place to prevent that from happening.
This has been this way for a long time already could it be that you are using a quite old version of this plugin or could you explain in more detail what you want?

@Lauriichan
Copy link
Member

It seems like there was a bug with the plugin for some time so only already damaged tools would be damaged by breaking blocks using SmoothTimber in minecraft 1.13 and up. So the description of the durability mechanics did not work for undamaged tools as it seems, so if you updated your plugin to atleast 1.24.6 the behaviour will be the same as I described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or suggestion Priority: Optional
Projects
None yet
Development

No branches or pull requests

2 participants