Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusion about boolean configuration values #4

Open
umlaeute opened this issue Jun 7, 2021 · 0 comments
Open

confusion about boolean configuration values #4

umlaeute opened this issue Jun 7, 2021 · 0 comments

Comments

@umlaeute
Copy link

umlaeute commented Jun 7, 2021

the build configuration obviously uses boolean values, e.g.

py/build/config-lnx.def

Lines 24 to 25 in 35138a0

# use python with pymalloc (look for "pythonX.Ym" files)
PY_USE_PYMALLOC=1

however, the build system does not check whether these values are set to a true value (that is: 1), but instead it is only important that the variable is assigned any value:

ifdef PY_USE_PYMALLOC

the consequence is that e.g. setting PY_USE_PYMALLOC=0 will still enable pymalloc, even though the declaration suggests otherwise.

I suggest to either

  • check whether a configuration variable is both defined and has a value of 1 (very much preferred)
  • or document that the actual value does not matter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant