SONARJAVA-3727 Update rules metadata (#3496)

Author: alban-auzeill

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S1120_java.json

@@ -7,7 +7,7 @@
     "constantCost": "1min"
   },
   "tags": [
-    "style"
+    "convention"
   ],
   "defaultSeverity": "Minor",
   "ruleSpecification": "RSPEC-1120",

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S122_java.json

@@ -7,7 +7,7 @@
     "constantCost": "1min"
   },
   "tags": [
-    "style"
+    "convention"
   ],
   "defaultSeverity": "Major",
   "ruleSpecification": "RSPEC-122",

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S1314_java.html

@@ -2,7 +2,7 @@
 have experience with them. They may not recognize octal values as such, mistaking them instead for decimal values.</p>
 <h2>Noncompliant Code Example</h2>
 <pre>
-int myNumber = 010;   // Noncompliant. myNumber will hold 8, not 10 - was this really expected?
+int myNumber = 010; // Noncompliant. myNumber will hold 8, not 10 - was this really expected?
 </pre>
 <h2>Compliant Solution</h2>
 <pre>

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2111_java.html

@@ -1,11 +1,11 @@
 <p>Because of floating point imprecision, you're unlikely to get the value you expect from the <code>BigDecimal(double)</code> constructor. </p>
 <p>From <a href="http://docs.oracle.com/javase/7/docs/api/java/math/BigDecimal.html#BigDecimal(double)">the JavaDocs</a>:</p>
 <blockquote>
-  The results of this constructor can be somewhat unpredictable. One might assume that writing new BigDecimal(0.1) in Java creates a BigDecimal which
-  is exactly equal to 0.1 (an unscaled value of 1, with a scale of 1), but it is actually equal to
+  <p>The results of this constructor can be somewhat unpredictable. One might assume that writing new BigDecimal(0.1) in Java creates a BigDecimal
+  which is exactly equal to 0.1 (an unscaled value of 1, with a scale of 1), but it is actually equal to
   0.1000000000000000055511151231257827021181583404541015625. This is because 0.1 cannot be represented exactly as a double (or, for that matter, as a
   binary fraction of any finite length). Thus, the value that is being passed in to the constructor is not exactly equal to 0.1, appearances
-  notwithstanding.
+  notwithstanding.</p>
 </blockquote>
 <p>Instead, you should use <code>BigDecimal.valueOf</code>, which uses a string under the covers to eliminate floating point rounding errors, or the
 constructor that takes a <code>String</code> argument.</p>

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2165_java.html

@@ -8,5 +8,7 @@ <h2>Noncompliant Code Example</h2>
   @Override
   void finalize() {
     name = null;  // Noncompliant; completely unnecessary
+  }
+}
 </pre>
 

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2658_java.json

@@ -7,19 +7,10 @@
     "constantCost": "45min"
   },
   "tags": [
-    "cwe",
-    "owasp-a1"
+    
   ],
   "defaultSeverity": "Critical",
   "ruleSpecification": "RSPEC-2658",
   "sqKey": "S2658",
-  "scope": "Main",
-  "securityStandards": {
-    "CWE": [
-      470
-    ],
-    "OWASP": [
-      "A1"
-    ]
-  }
+  "scope": "Main"
 }

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2786_java.html

@@ -1,7 +1,6 @@
 <p>According to <a href="http://docs.oracle.com/javase/specs/jls/se7/html/jls-8.html#jls-8.9">the Java Language Specification-8.9</a>:</p>
 <blockquote>
-  Nested enum types are implicitly
-  <code>static</code>.
+  <p>Nested enum types are implicitly <code>static</code>.</p>
 </blockquote>
 <p>So there's no need to declare them <code>static</code> explicitly.</p>
 <h2>Noncompliant Code Example</h2>

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S2975_java.html

@@ -1,11 +1,11 @@
 <p>Many consider <code>clone</code> and <code>Cloneable</code> broken in Java, largely because the rules for overriding <code>clone</code> are tricky
 and difficult to get right, according to Joshua Bloch:</p>
 <blockquote>
-  Object's clone method is very tricky. It's based on field copies, and it's "extra-linguistic." It creates an object without calling a constructor.
-  There are no guarantees that it preserves the invariants established by the constructors. There have been lots of bugs over the years, both in and
-  outside Sun, stemming from the fact that if you just call super.clone repeatedly up the chain until you have cloned an object, you have a shallow
-  copy of the object. The clone generally shares state with the object being cloned. If that state is mutable, you don't have two independent objects.
-  If you modify one, the other changes as well. And all of a sudden, you get random behavior.
+  <p>Object's clone method is very tricky. It's based on field copies, and it's "extra-linguistic." It creates an object without calling a
+  constructor. There are no guarantees that it preserves the invariants established by the constructors. There have been lots of bugs over the years,
+  both in and outside Sun, stemming from the fact that if you just call super.clone repeatedly up the chain until you have cloned an object, you have
+  a shallow copy of the object. The clone generally shares state with the object being cloned. If that state is mutable, you don't have two
+  independent objects. If you modify one, the other changes as well. And all of a sudden, you get random behavior. </p>
 </blockquote>
 <p>A copy constructor or copy factory should be used instead.</p>
 <p>This rule raises an issue when <code>clone</code> is overridden, whether or not <code>Cloneable</code> is implemented.</p>

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S3281_java.html

@@ -1,5 +1,5 @@
 <p>Default interceptors, such as application security interceptors, must be listed in the <code>ejb-jar.xml</code> file, or they will not be treated
-as default. </p>
+as default.</p>
 <p>This rule applies to projects that contain JEE Beans (any one of <code>javax.ejb.Singleton</code>, <code>MessageDriven</code>,
 <code>Stateless</code> or <code>Stateful</code>).</p>
 <h2>Noncompliant Code Example</h2>
@@ -8,7 +8,7 @@ <h2>Noncompliant Code Example</h2>
 &lt;assembly-descriptor&gt;
  &lt;interceptor-binding&gt; &lt;!-- should be declared in ejb-jar.xml --&gt;
       &lt;ejb-name&gt;*&lt;/ejb-name&gt;
-      &lt;interceptor-class&gt;com.myco.ImportantInterceptor&lt;/interceptor-class&gt;&lt;!-- Noncompliant; will NOT be treated as default --&gt;
+      &lt;interceptor-class&gt;com.myco.ImportantInterceptor&lt;/interceptor-class&gt; &lt;!-- Noncompliant; will NOT be treated as default --&gt;
    &lt;/interceptor-binding&gt;
 &lt;/assembly-descriptor&gt;
 </pre>

java-checks/src/main/resources/org/sonar/l10n/java/rules/java/S3369_java.html

@@ -8,4 +8,4 @@ <h2>See</h2>
 </ul>
 <h2>Deprecated</h2>
 <p>This rule is deprecated, and will eventually be removed.</p>
-
+