From 10302ab01003933abf482ca9b77c9a9cecbdbb60 Mon Sep 17 00:00:00 2001 From: Michael Gumowski Date: Fri, 23 Dec 2016 14:07:35 +0100 Subject: [PATCH] Fix quality flaw: increase check coverage --- .../test/files/checks/NoTestInTestClassCheck.java | 13 +++++++++++++ .../java/checks/NoTestInTestClassCheckTest.java | 1 + 2 files changed, 14 insertions(+) diff --git a/java-checks/src/test/files/checks/NoTestInTestClassCheck.java b/java-checks/src/test/files/checks/NoTestInTestClassCheck.java index afce4203f71..f4c04977d13 100644 --- a/java-checks/src/test/files/checks/NoTestInTestClassCheck.java +++ b/java-checks/src/test/files/checks/NoTestInTestClassCheck.java @@ -98,6 +98,19 @@ public class MyCucumberTest { // should not raise an issue public class MyCucumber2Test { // no issue } +@RunWith(MyRunner.class) +public class MyCucumber3Test { // Noncompliant - not recognized +} +@RunWith(getRunner()) +public class MyCucumber4Test { // Noncompliant - does not compile, not a class literal + public Class getRunner() { + return null; + } +} +@RunWith(value1= MyRunner.class, value2= YourRunner.class) +public class MyCucumber5Test { // Noncompliant - does not compile, not a class literal +} + public class CTest { @org.junit.jupiter.api.Test // no issue, junit5 annotation public void testFoo() { diff --git a/java-checks/src/test/java/org/sonar/java/checks/NoTestInTestClassCheckTest.java b/java-checks/src/test/java/org/sonar/java/checks/NoTestInTestClassCheckTest.java index ab0329a18ca..52a4294cd31 100644 --- a/java-checks/src/test/java/org/sonar/java/checks/NoTestInTestClassCheckTest.java +++ b/java-checks/src/test/java/org/sonar/java/checks/NoTestInTestClassCheckTest.java @@ -30,6 +30,7 @@ public class NoTestInTestClassCheckTest { @Test public void test() { JavaCheckVerifier.verify("src/test/files/checks/NoTestInTestClassCheck.java", new NoTestInTestClassCheck()); + JavaCheckVerifier.verifyNoIssueWithoutSemantic("src/test/files/checks/NoTestInTestClassCheck.java", new NoTestInTestClassCheck()); } @Test