Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Arithmetic in Opcodes #5

Open
Solumin opened this issue Oct 19, 2014 · 3 comments
Open

Mixed Arithmetic in Opcodes #5

Solumin opened this issue Oct 19, 2014 · 3 comments
Assignees

Comments

@Solumin
Copy link
Owner

Solumin commented Oct 19, 2014

I've added a sample of mixed arithmetic to BINARY_ADD. It's really messy -- another way to do this would be great.

One problem is that we're treating 32-bit integers as 'numbers', so they look like floating-point numbers, which messes up the widening hierarchy (see the comment on interpreter.ts:widen or Python Numeric Types)

@Solumin
Copy link
Owner Author

Solumin commented Oct 19, 2014

I'm tempted to unmarshal all 32-bit integers as gLong types (64 bit), just so they follow the hierarchy a little better.

@cibelemf
Copy link
Collaborator

Did you try to do that? I saw you changed the widen and other stuff. Is it working now?

@Solumin
Copy link
Owner Author

Solumin commented Oct 19, 2014

I got it working for BINARY_ADD but it's so clunky and ugly.

On Sun, Oct 19, 2014 at 4:54 PM, Cibele [email protected] wrote:

Did you try to do that? I saw you changed the widen and other stuff. Is it
working now?


Reply to this email directly or view it on GitHub
#5 (comment)
.

@Solumin Solumin self-assigned this Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants