Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No errors when text-block-define is unable to read the file #90

Open
ywkaras opened this issue Nov 24, 2022 · 1 comment
Open

No errors when text-block-define is unable to read the file #90

ywkaras opened this issue Nov 24, 2022 · 1 comment

Comments

@ywkaras
Copy link
Contributor

ywkaras commented Nov 24, 2022

& worse, when a request comes through using that text-block, it doesn't even inject anything!!!

Example:

-rwx------ 1 vinithb users 5 Nov 23 23:41 /home/y/conf/trafficserver/ssl/athenz/mail.backend.jedi.jws.acl_jedi.acl.token.atz.jws.ycpi.yahoo.jwt 
    - text-block-define:
        name: "JWT-mail_cloud-mail.backend.jedi.jws.acl_jedi.acl.token.atz.jws.ycpi.yahoo.jwt"
        path: "/home/y/conf/trafficserver/ssl/athenz/mail.backend.jedi.jws.acl_jedi.acl.token.atz.jws.ycpi.yahoo.jwt"
        duration: "1m" 

Expectation:
Since this is a per-remap plugin, ATS can't fatal but at a minimum, we need an entry in diags/error.log and/or 502 the request.

Found by Yahoo YCPI (Vineeth Bindiganavale). Internal Yahoo issue ID: YTSATS-4083.

This issue was probably seen in 0.4.10 .

@ywkaras
Copy link
Contributor Author

ywkaras commented Jan 5, 2023

Vinith is waiting on this fix. He may start calling somebody Solid Wall of Retired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant