Replace internal map usage with slices #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be significant when dealing with thousands of objects.
Open
|
Yo, thanks for the PR - I ended up massively updating Resolv and I don't use maps anymore internally for ignoring. Thank you very much for the PR, though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently optimizing a particle effects subsystem and am running into some performance issues with a large amount of particles (1000+). Although I'm not expecting there to be that many particles with physics enabled, I fully expect there to be an impact from them during complex scenes (I was already seeing this, but optimized my own code as well to make it a bit better). My primary game map developer has a penchant for using lots of available systems to make things look really nice, but this comes at the cost of my own time spent optimizing.
At any rate, after some profiling, removing the usage of maps in a few locations (the ignore list and within the Object.Check func) gives a decent increase in performance -- was able to reduce
Check's processing time by around 5 seconds (from 7.5 to 2.5, roughly). Clipped profiling is provided below.