Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileNumberingFilterWriterTest does not flush streams before reading them. #8

Open
ltouroumov opened this issue Mar 14, 2016 · 2 comments

Comments

@ltouroumov
Copy link

Which causes the edge case of having a \r as the last character in a stream to be impossible to process without parent stream backtracking.

@ltouroumov
Copy link
Author

Fixed in d11dc726df126efd2986b978853bc69e01a6ebf1

  • Updated tests to call flush() before reading contents.
  • Added test with \r as the last character of a stream.

@wasadigi
Copy link
Member

Very good point. I did something similar (adding a test, fixing the implementation and fixing the test). But in my case, I took care of the edge case in the close() method implementation and so I added a call to close() in the test (it should have been there from the beginning...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants