Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Microsoft and Azure provider #1138

Open
buddhaCode opened this issue Jan 15, 2024 · 4 comments
Open

Merge Microsoft and Azure provider #1138

buddhaCode opened this issue Jan 15, 2024 · 4 comments

Comments

@buddhaCode
Copy link

Hi folks,
Hi @atymic,
I was wondering what the difference between these two providers are. As far as I found out, I can use both to authenticate against an Azure AD. Is that right?

Best,
Arne

@atymic atymic changed the title What's the difference between the Microsoft and Azure provider Merge Microsoft and Azure provider Feb 7, 2024
@atymic
Copy link
Member

atymic commented Feb 7, 2024

That's a good question.
Looking at the code, it seems you are correct. I think we should deprecate one of them, probably the azure one.
The azure one seems to support proxies, but apart from that the microsoft provider seems to have more features.

@atymic
Copy link
Member

atymic commented Feb 7, 2024

I would probably use the Microsoft one, PRSs welcome to add the proxy feature to the Microsoft one, and test to make sure it works as expected :)

@buddhaCode
Copy link
Author

Okay thanks for your reply. Indeed, we migrated from the Azure to the Microsoft provider.

We need to access some custom attribute on the user data. But after an update of the Azure provider this wasn't possible anymore. But with the Microsoft provider it's still possible to retrieve extra custom attributes.

kinekt4 pushed a commit to kinekt4/Socialite-Providers that referenced this issue May 8, 2024
atymic pushed a commit that referenced this issue May 13, 2024
@atymic
Copy link
Member

atymic commented Jun 30, 2024

I've brought across proxy support in #1226
Is there anything missing from the azure provider now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants