fix: Prevent 0 on renumeration results step if declaration modified (#2163)

Author: arturlg

packages/app/src/app/(default)/index-egapro/declaration/remunerations/RemunerationForm.tsx

@@ -158,6 +158,10 @@ export const RemunerationForm = () => {
         draft["remunerations-resultat"] = undefined;
         savePageData("remunerations-resultat", undefined);
       }
+      if (data.estCalculable === "oui" && formData[stepName]?.estCalculable === "non") {
+        draft["remunerations-resultat"] = undefined;
+        savePageData("remunerations-resultat", undefined);
+      }
       if (data.estCalculable !== formData[stepName]?.estCalculable) {
         draft[stepName] = getModifiedFormValues(dirtyFields, data) as DeclarationDTO[typeof stepName];
       } else {

packages/app/src/app/(default)/index-egapro/declaration/resultat-global/ResultatGlobalForm.tsx

@@ -60,16 +60,12 @@ export const ResultatGlobalForm = () => {
 
   const computed = computeDeclarationIndex(DeclarationComputerInputBuilder.fromDeclarationDTO(formData));
 
-  // We don't compute the index if we only read an existing declaration.
-  const defaultValues =
-    formData["declaration-existante"].status === "consultation"
-      ? formData[stepName]
-      : {
-          ...formData[stepName],
-          index: computed.index,
-          points: computed.points,
-          pointsCalculables: computed.computablePoints,
-        };
+  const defaultValues = {
+    ...formData[stepName],
+    index: computed.index,
+    points: computed.points,
+    pointsCalculables: computed.computablePoints,
+  };
 
   const methods = useForm<FormType>({
     mode: "onChange",