Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Parser enclosure should be user definable #50

Open
AaronHolbrook opened this issue Jul 12, 2019 · 0 comments
Open

CSV Parser enclosure should be user definable #50

AaronHolbrook opened this issue Jul 12, 2019 · 0 comments

Comments

@AaronHolbrook
Copy link

I am running into an issue where there is a comma within a cell but it is properly enclosed in a quotation marks.

https://github.com/SoapBox/laravel-formatter/blob/master/src/Parsers/CsvParser.php#L18

However, due to the setEnclosure being hardcoded to a pipe character, the parsing is breaking and ignoring the enclosure.

I propose allowing users of this package to simply define the enclosure to be whatever they need.

AaronHolbrook added a commit to AaronHolbrook/laravel-formatter that referenced this issue Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant