From 21d5daaa6b6b4a5f45f47b4c385b07cdaa4224b3 Mon Sep 17 00:00:00 2001 From: Martyna Maciejewska Date: Tue, 30 Jan 2024 12:47:23 +0100 Subject: [PATCH 1/4] Added fixes in the function fetchTitleData --- Model/ResourceModel/NodeType/Product.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Model/ResourceModel/NodeType/Product.php b/Model/ResourceModel/NodeType/Product.php index d1334aa8..e6158e94 100644 --- a/Model/ResourceModel/NodeType/Product.php +++ b/Model/ResourceModel/NodeType/Product.php @@ -106,7 +106,7 @@ public function fetchConfigData() public function fetchTitleData($storeId = Store::DEFAULT_STORE_ID, $productIds = []) { $collection = $this->productCollection->create(); - $collection->addAttributeToSelect(['name', 'left']) + $collection->addAttributeToSelect('name', 'left') ->addFieldToFilter('entity_id', ['in' => $productIds]) ->addStoreFilter($storeId); From d2abff46df22a95fb0580c4bddd0a94a116b52d7 Mon Sep 17 00:00:00 2001 From: Martyna Maciejewska Date: Tue, 30 Jan 2024 12:54:13 +0100 Subject: [PATCH 2/4] Fixed pipeline issue 'Referenced sniff PHPCompatibility.FunctionUse.RemovedFunctions does not exist' --- composer.json | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 0f82d516..05ad5ce7 100644 --- a/composer.json +++ b/composer.json @@ -32,7 +32,10 @@ }, "scripts": { "test": "vendor/bin/phpcs -s --colors --standard=Magento2 --exclude=Magento2.Security.XssTemplate --ignore=vendor --extensions=php,phtml *", - "post-install-cmd": "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)", + "post-install-cmd": [ + "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)", + "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/,../../phpcompatibility/php-compatibility)" + ], "post-update-cmd": "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)" } } From 2dfe0112496e6907266866c700ebff2896972450 Mon Sep 17 00:00:00 2001 From: Martyna Maciejewska Date: Tue, 30 Jan 2024 13:00:33 +0100 Subject: [PATCH 3/4] Revert changes in composer.json --- composer.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/composer.json b/composer.json index 05ad5ce7..0f82d516 100644 --- a/composer.json +++ b/composer.json @@ -32,10 +32,7 @@ }, "scripts": { "test": "vendor/bin/phpcs -s --colors --standard=Magento2 --exclude=Magento2.Security.XssTemplate --ignore=vendor --extensions=php,phtml *", - "post-install-cmd": [ - "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)", - "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/,../../phpcompatibility/php-compatibility)" - ], + "post-install-cmd": "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)", "post-update-cmd": "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/)" } } From 096a9930512a26a38dbc14d91a16c8b765bd4b11 Mon Sep 17 00:00:00 2001 From: Martyna Maciejewska Date: Tue, 6 Feb 2024 09:15:07 +0100 Subject: [PATCH 4/4] Updated CHANGELOG.md file --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 984368be..0e7c2277 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] +### Fixed +- The function getProductTitle() returns empty string (DEV-104749) ## [2.25.0] - 2024-01-19 ### Added