Error in sample code checking flags #66
Comments
tomstokes
added a commit
to tomstokes/input.rs
that referenced
this issue
Nov 8, 2024
The original code masks flags with O_RDONLY, which is 0: ``` .read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0)) .write((flags & O_WRONLY != 0) | (flags & O_RDWR != 0)) ``` This generates Clippy errors because it's equivalent to 0 & 0 != 0. The correct code uses O_ACCMODE to mask off the lower bits: ``` .read((flags & O_ACCMODE == O_RDONLY) | (flags & O_ACCMODE == O_RDWR)) .write((flags & O_ACCMODE == O_WRONLY) | (flags & O_ACCMODE == O_RDWR)) ``` The code could be further simplified with `let access_flags = flags & O_ACCMODE` at the top, but this version maintains the original intent and consistency with similar libinput examples across the internet. This commit updates all 3 occurrences of the code fragment. Fixes Smithay#66 Signed-off-by: Tom Stokes <[email protected]>
tomstokes
added a commit
to tomstokes/input.rs
that referenced
this issue
Nov 8, 2024
The original code masks flags with O_RDONLY, which is 0: ``` .read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0)) .write((flags & O_WRONLY != 0) | (flags & O_RDWR != 0)) ``` This generates Clippy errors because it's equivalent to 0 & 0 != 0. The correct code uses O_ACCMODE to mask off the lower bits: ``` .read((flags & O_ACCMODE == O_RDONLY) | (flags & O_ACCMODE == O_RDWR)) .write((flags & O_ACCMODE == O_WRONLY) | (flags & O_ACCMODE == O_RDWR)) ``` The code could be further simplified with `let access_flags = flags & O_ACCMODE` at the top, but this version maintains the original intent and consistency with similar libinput examples across the internet. This commit updates all 3 occurrences of the code fragment. Fixes Smithay#66 Signed-off-by: Tom Stokes <[email protected]>
tomstokes
added a commit
to tomstokes/input.rs
that referenced
this issue
Nov 8, 2024
The original code masks flags with O_RDONLY, which is 0: > .read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0)) This generates Clippy errors because it's equivalent to 0 & 0 != 0. The correct code uses O_ACCMODE to mask off the lower bits: > .read((flags & O_ACCMODE == O_RDONLY) | (flags & O_ACCMODE == O_RDWR)) The code could be further simplified with `let access_flags = flags & O_ACCMODE` at the top, but this version maintains the original intent and consistency with similar libinput examples across the internet. This commit updates all 3 occurrences of the code fragment. Fixes Smithay#66 Signed-off-by: Tom Stokes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The sample code contains the follow tests:
However
O_RDONLYis0so the test is bogus and gives a clippy warning.The
O_XXXXvalues are not bit masks but rather they are values for the two low order bits of theflagsvalue. The tests should probably look somethign like this:The text was updated successfully, but these errors were encountered: