You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> Some of the translation strings were missing from the fallback translation dict. Fixes #17.
Wrong, it doesn't fix #17, because the extension deletes all hardcoded tables upon closing, so re-opening the window fails due to an ipairs(nil) call.
Overly aggressive cleanup or missing reactivation logic
-- Function triggered when the extension is activated
function activate()
vlc.msg.dbg(_VERSION) --display Lua version in the VLC message window
vlc.msg.dbg("[Lyrics Finder] Activating ")
langcode = getenv_lang() --auto guess
if dlg then
dlg:show()
end
show_dialog()
return true
end
function close()
deactivate()
end
-- Function triggered when the extension is deactivated
function deactivate()
reset_variables()
vlc.deactivate()
vlc.msg.dbg("[Lyrics Finder] Deactivated")
return true
end
Specifically the method "reset_variables()":
-- Resets dialog
function reset_variables()
dlg = nil
title = nil
artist = nil
lyric = nil
source_label = nil
languages = nil
translation = nil
end
The "languages" and "translation" KV tables are defined at the beginning of the lua file and get emptied in memory upon unloading the window.
Wrong, it doesn't fix #17, because the extension deletes all hardcoded tables upon closing, so re-opening the window fails due to an ipairs(nil) call.
Overly aggressive cleanup or missing reactivation logic
Specifically the method "reset_variables()":
The "languages" and "translation" KV tables are defined at the beginning of the lua file and get emptied in memory upon unloading the window.
Originally posted by @LittleCyberCortex in #19 (comment)
The text was updated successfully, but these errors were encountered: