Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dash issue with composed names #14

Open
Katoru opened this issue Nov 14, 2018 · 2 comments
Open

Removing dash issue with composed names #14

Katoru opened this issue Nov 14, 2018 · 2 comments

Comments

@Katoru
Copy link

Katoru commented Nov 14, 2018

Hi,

I noticed that if the artist name is composed and contain a dash, it might broke the lyrics research.

Here is an exemple.
The real spelling is Sophie Ellis-Bextor. With the dash remover in the code it ends up being Sophie EllisBextor making the artist unfindable because it's either referred as Sophie Ellis Bextor or Sophie-Ellis-Bextor or Sophie_Ellis_Bextor depending the website.

I ended up editing my whole library to remove dash holder artists names. But MP3 ripped from original CDs and bought MP3 give artist name with the dash when it's their real spelling.

I hope my english was not that bad.

Regards

@Smile4ever
Copy link
Owner

Thank you for your input. I'll have a look at it to improve the handling of dashes.

@Katoru
Copy link
Author

Katoru commented Nov 14, 2018

Thank you for your job on this plugin btw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants